Review main Merged Breaking

79321[!!!][TASK] Remove deprecated code in PageRepository

Benni Mack CR +2 V +2 Normal +17 −213 updated 06/14/23, 11:08

Commit message

Removed interfaces:
* `\TYPO3\CMS\Core\Domain\Repository\PageRepositoryGetPageOverlayHookInterface`
* `\TYPO3\CMS\Core\Domain\Repository\PageRepositoryGetRecordOverlayHookInterface`

Changed visibility for methods and properties:
* `\TYPO3\CMS\Core\Domain\Repository\PageRepository->getRecordOverlay()`
* `\TYPO3\CMS\Core\Domain\Repository\PageRepository->where_hid_del`
* `\TYPO3\CMS\Core\Domain\Repository\PageRepository->where_groupAccess`

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 4

Files 8

Review log 711

  1. Benni Mack uploaded patch set 1 06/13/23, 20:27

  2. core-ci voted on patch set 1 V -1 06/13/23, 20:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42489

  3. Benni Mack updated the commit message in patch set 2 V -1 06/13/23, 21:02

  4. core-ci voted on patch set 2 V -1 06/13/23, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42494

  5. Benni Mack uploaded patch set 3 V -1 06/13/23, 22:46

  6. core-ci voted on patch set 3 V -1 06/13/23, 22:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42503

  7. Benni Mack uploaded patch set 4 V -1 06/13/23, 23:24

  8. core-ci voted on patch set 4 V +1 06/13/23, 23:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42504

  9. Nikita Hovratov voted on patch set 4 V +1 CR +1 06/14/23, 07:20

  10. Christian Kuhn voted on patch set 4 V +2 CR +2 06/14/23, 11:08

  11. Christian Kuhn merged patch set 5 06/14/23, 11:08