Review main Merged Breaking

79322[!!!][TASK] Remove deprecated LanguageService-related settings

Benni Mack CR +2 V +2 Normal +19 −158 updated 06/15/23, 08:08

Commit message

Removed configuration option:
* $GLOBALS['TYPO3_CONF_VARS']['BE']['languageDebug']

Removed public property:
* TYPO3\CMS\Core\Localization\LanguageService->debugKey

Removed public methods:
* TYPO3\CMS\Core\Localization\LanguageService->getLL
* TYPO3\CMS\Core\Localization\Locales->getIsoMapping

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 4

Files 11

Review log 1114

  1. Benni Mack uploaded patch set 1 06/13/23, 21:13

  2. core-ci voted on patch set 1 V -1 06/13/23, 21:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42495

  3. Benni Mack commented on patch set 1 CR -2 06/14/23, 11:13

    Reason for -1: There is a problem with an existing upgrade wizard migration, which first needs to be solved.
  4. Stefan Bürk uploaded patch set 2 V -1 06/15/23, 07:25

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  5. core-ci voted on patch set 2 V +1 06/15/23, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42641

  6. Oliver Klee voted on patch set 2 V +1 06/15/23, 07:37

  7. Oliver Klee voted on patch set 2 CR +1 06/15/23, 07:39

  8. Stefan Bürk uploaded patch set 3 CR +1 V +1 06/15/23, 07:54

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  9. Stefan Bürk voted on patch set 3 V +1 CR +1 06/15/23, 07:55

  10. Benni Mack voted on patch set 3 CR 0 06/15/23, 07:58

  11. core-ci voted on patch set 3 V +1 06/15/23, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42642

  12. Oliver Klee voted on patch set 3 V +1 CR +1 06/15/23, 08:06

  13. Benni Mack voted on patch set 3 V +2 CR +2 06/15/23, 08:08

  14. Benni Mack merged patch set 4 06/15/23, 08:08