Review main Merged Breaking

79327[!!!][TASK] Remove deprecated code ContextualFeedbackSeverity

Thomas Hohn CR +2 V +2 Normal +59 −151 updated 06/14/23, 19:53

Commit message

Removed the following public method:
* \TYPO3\CMS\Core\Type\ContextualFeedbackSeverity::transform

Removed the following public constants:
* \TYPO3\CMS\Core\Messaging\AbstractMessage::ERROR
* \TYPO3\CMS\Core\Messaging\AbstractMessage::INFO
* \TYPO3\CMS\Core\Messaging\AbstractMessage::NOTICE
* \TYPO3\CMS\Core\Messaging\AbstractMessage::OK
* \TYPO3\CMS\Core\Messaging\AbstractMessage::WARNING
* \TYPO3\CMS\Core\Messaging\FlashMessage::ERROR
* \TYPO3\CMS\Core\Messaging\FlashMessage::INFO
* \TYPO3\CMS\Core\Messaging\FlashMessage::NOTICE
* \TYPO3\CMS\Core\Messaging\FlashMessage::OK
* \TYPO3\CMS\Core\Messaging\FlashMessage::WARNING
* \TYPO3\CMS\Reports\Status::ERROR
* \TYPO3\CMS\Reports\Status::INFO
* \TYPO3\CMS\Reports\Status::NOTICE
* \TYPO3\CMS\Reports\Status::OK
* \TYPO3\CMS\Reports\Status::WARNING

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 11

Review log 1827

Show 12 earlier messages
  1. Thomas Hohn uploaded patch set 1 06/14/23, 06:40

  2. core-ci voted on patch set 1 V -1 06/14/23, 06:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42512

  1. Benni Mack commented on patch set 1 06/14/23, 07:05

  2. Thomas Hohn uploaded patch set 2 V -1 06/14/23, 07:10

  3. core-ci voted on patch set 2 V +1 06/14/23, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42513

  4. Thomas Hohn commented on patch set 2 06/14/23, 07:19

    Reply

    No problem - if you fix the merge conflicts in that patch I can review it
  5. Nikita Hovratov voted on patch set 2 V +1 CR +1 06/14/23, 07:24

  6. Thomas Hohn rebased onto patch set 3 CR +1 V +1 06/14/23, 11:08

    The following files contain Git conflicts: * typo3/sysext/core/Documentation/Changelog/13.0/Breaking-100963-DeprecatedFunctionalityRemoved.rst
  7. Thomas Hohn rebased onto patch set 4 06/14/23, 11:15

  8. core-ci voted on patch set 4 V +1 06/14/23, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42534

  9. Thomas Hohn uploaded patch set 5 V +1 06/14/23, 11:30

  10. core-ci voted on patch set 3 V +1 06/14/23, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42531

  11. Thomas Hohn uploaded patch set 6 06/14/23, 11:36

  12. core-ci voted on patch set 5 V +1 06/14/23, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42538

  13. core-ci voted on patch set 6 V +1 06/14/23, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42539

  14. Thomas Hohn marked it ready for review 06/14/23, 11:58

  15. Andreas Kienast voted on patch set 6 CR +1 06/14/23, 13:13

  16. Thomas Hohn rebased onto patch set 7 CR +1 V +1 06/14/23, 13:42

    The following files contain Git conflicts: * typo3/sysext/core/Documentation/Changelog/13.0/Breaking-100963-DeprecatedFunctionalityRemoved.rst
  17. core-ci voted on patch set 7 V +1 06/14/23, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42551

  18. Thomas Hohn uploaded patch set 8 V +1 06/14/23, 16:32

  19. Thomas Hohn marked it ready for review 06/14/23, 16:32

  20. core-ci voted on patch set 8 V +1 06/14/23, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42587

  21. Christian Kuhn uploaded patch set 9 V +1 06/14/23, 17:15

  22. Christian Kuhn voted on patch set 9 V +1 CR +1 06/14/23, 17:16

  23. core-ci voted on patch set 9 V +1 06/14/23, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42590

  24. Anja Leichsenring voted on patch set 9 V +2 CR +2 06/14/23, 19:53

  25. Anja Leichsenring merged patch set 10 06/14/23, 19:53