Review main Merged Breaking

79331[!!!][TASK] Remove deprecated code in UserSessionManager

Thomas Hohn CR +2 V +2 Easy +2 −19 updated 06/14/23, 12:24

Commit message

Removed public methods:
* \TYPO3\CMS\Core\Session\UserSessionManager->
  createFromGlobalCookieOrAnonymous

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1520

  1. Thomas Hohn uploaded patch set 1 06/14/23, 08:13

  2. core-ci voted on patch set 1 V +1 06/14/23, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42525

  3. Benni Mack voted on patch set 1 V +1 CR +1 06/14/23, 08:46

  4. Thomas Hohn rebased onto patch set 2 CR +1 V +1 06/14/23, 11:09

    The following files contain Git conflicts: * typo3/sysext/core/Documentation/Changelog/13.0/Breaking-100963-DeprecatedFunctionalityRemoved.rst
  5. Thomas Hohn uploaded patch set 3 06/14/23, 11:12

  6. Thomas Hohn marked it ready for review 06/14/23, 11:13

  7. Benni Mack commented on patch set 3 06/14/23, 11:19

    Breaking-100963-DeprecatedFunctionalityRemoved.rst:115

    there is something off here ;)
  8. core-ci voted on patch set 3 V +1 06/14/23, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42533

  9. core-ci voted on patch set 2 V +1 06/14/23, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42532

  10. Thomas Hohn commented on patch set 3 06/14/23, 11:32

    Breaking-100963-DeprecatedFunctionalityRemoved.rst:115 Reply

    Ah yes - they should have been removed -right?
  11. Thomas Hohn commented on patch set 3 06/14/23, 11:45

  12. Stefan Bürk commented on patch set 3 06/14/23, 11:48

    Breaking-100963-DeprecatedFunctionalityRemoved.rst:115 Reply

  13. Thomas Hohn uploaded patch set 4 V +1 06/14/23, 12:02

  14. Thomas Hohn commented on patch set 4 06/14/23, 12:02

    Breaking-100963-DeprecatedFunctionalityRemoved.rst:115 Reply

    Ack
  15. core-ci voted on patch set 4 V +1 06/14/23, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42542

  16. Oli Bartsch updated the commit message in patch set 5 V +1 06/14/23, 12:12

  17. Oli Bartsch voted on patch set 5 V +1 CR +1 06/14/23, 12:12

  18. core-ci voted on patch set 5 V +1 06/14/23, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42543

  19. Stefan Bürk voted on patch set 5 V +2 CR +2 06/14/23, 12:24

  20. Stefan Bürk merged patch set 6 06/14/23, 12:24