Review main Merged Breaking

79333[!!!][TASK] Remove deprecated class RequireJsController

Thomas Hohn CR +2 V +2 Normal +6 −127 updated 06/14/23, 11:52

Commit message

Removed the following public class:
* \TYPO3\CMS\Core\Controller\RequireJsController

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 912

  1. Thomas Hohn uploaded patch set 1 06/14/23, 10:27

  2. core-ci voted on patch set 1 V +1 06/14/23, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42529

  3. Benni Mack commented on patch set 1 06/14/23, 10:42

    We should also document that the AJAX Route is gone and the eID
  4. Thomas Hohn commented on patch set 1 06/14/23, 10:43

    Reply

    Will do 😊
  5. Thomas Hohn uploaded patch set 2 V +1 06/14/23, 10:57

  6. core-ci voted on patch set 2 V +1 06/14/23, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42530

  7. Benni Mack commented on patch set 2 CR -1 06/14/23, 11:12

    will adapt.
  8. Benni Mack uploaded patch set 3 CR -1 V +1 06/14/23, 11:18

  9. Benni Mack voted on patch set 3 V +1 CR +1 06/14/23, 11:18

  10. core-ci voted on patch set 3 V +1 06/14/23, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42536

  11. Stefan Bürk voted on patch set 3 V +2 CR +2 06/14/23, 11:52

  12. Stefan Bürk merged patch set 4 06/14/23, 11:52