Review main Merged Breaking

79336[!!!][TASK] Remove deprecated usage of 'additionalJavaScriptPost'

Thomas Hohn CR +2 V +2 Normal +3 −63 updated 06/14/23, 16:22

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 11

Review log 78

  1. Thomas Hohn uploaded patch set 1 06/14/23, 12:41

  2. core-ci voted on patch set 1 V +1 06/14/23, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42547

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 06/14/23, 13:03

  4. Christian Kuhn commented on patch set 1 V 0 CR -1 06/14/23, 13:08

    FormFilesAjaxController.php:425

    it looks as if scriptCall[] is obsolete as well, now (some occurrences in js and php). should we do that now, or have a dedicated patch for this?
  5. Thomas Hohn commented on patch set 1 06/14/23, 13:13

    FormFilesAjaxController.php:425 Reply

    I would prefer a dedicated patch to keep the patches "small"
  6. Christian Kuhn commented on patch set 1 V +1 CR +1 06/14/23, 15:57

    FormFilesAjaxController.php:425 Reply

    Ack
  7. Stefan Bürk voted on patch set 1 V +2 CR +2 06/14/23, 16:22

  8. Stefan Bürk merged patch set 2 06/14/23, 16:22