Review main Merged Breaking

79379[!!!][TASK] Remove deprecated code ExtensionManagementUtility

Thomas Hohn CR +2 V +2 Normal +12 −115 updated 06/15/23, 22:15

Commit message

Removed public static methods in class
\TYPO3\CMS\Core\Utility\ExtensionManagementUtility:

* addModule
* insertModuleFunction
* addNavigationComponent
* addCoreNavigationComponent
* allowTableOnStandardPages

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 6

Files 8

Review log 1520

  1. Thomas Hohn uploaded patch set 1 06/14/23, 17:21

  2. Christian Kuhn commented on patch set 1 CR -1 06/14/23, 17:22

    let's wait until my csh patch is done, then see what is left.
  3. core-ci voted on patch set 1 V -1 06/14/23, 17:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42593

  4. Thomas Hohn uploaded patch set 2 CR -1 V -1 06/15/23, 13:33

  5. core-ci voted on patch set 2 V -1 06/15/23, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42660

  6. Thomas Hohn uploaded patch set 3 V -1 06/15/23, 15:15

  7. core-ci voted on patch set 3 V +1 06/15/23, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42667

  8. Oliver Klee commented on patch set 3 06/15/23, 16:00

    TcaMigration.php:1256

    It looks like `$additionalInformation` now is only written, but never read, and hence can be removed.
  9. Thomas Hohn commented on patch set 3 06/15/23, 16:19

    TcaMigration.php:1256 Reply

    I guess it should be re-added - only the place it's written is "deprecated"
  10. Thomas Hohn uploaded patch set 4 V +1 06/15/23, 16:29

  11. Thomas Hohn commented on patch set 4 06/15/23, 16:30

    TcaMigration.php:1256 Reply

    Done
  12. Oliver Klee voted on patch set 4 V +1 CR +1 06/15/23, 16:32

  13. core-ci voted on patch set 4 V +1 06/15/23, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42672

  14. Christian Kuhn voted on patch set 4 CR -1 06/15/23, 20:33

  15. Christian Kuhn uploaded patch set 5 CR +1 V +1 06/15/23, 20:50

  16. Christian Kuhn voted on patch set 5 V +1 CR +1 06/15/23, 20:51

  17. core-ci voted on patch set 5 V +1 06/15/23, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42694

  18. Oliver Klee voted on patch set 5 V +1 CR +1 06/15/23, 21:48

  19. Stefan Bürk voted on patch set 5 V +2 CR +2 06/15/23, 22:15

  20. Stefan Bürk merged patch set 6 06/15/23, 22:15