Review main Merged Breaking

79382[!!!][TASK] Remove obsolete method `QueryBuilder->execute()`

Stefan Bürk CR +2 V +2 Easy +1 −27 updated 06/14/23, 20:43

Commit message

Removes obsolete method:

* `\TYPO3\CMS\Core\Database\Query\QueryBuilder->execute()`

Note: Due to the fact that the `execute()` method
      would have found quite a lot false-positives
      by the ExtensionScanner, deprecation
      rest file are not added to a scanner match entry.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 1014

  1. Stefan Bürk uploaded patch set 1 06/14/23, 19:25

  2. core-ci voted on patch set 1 V +1 06/14/23, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42596

  3. Stefan Bürk updated the commit message in patch set 2 V +1 06/14/23, 19:47

  4. core-ci voted on patch set 2 V +1 06/14/23, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42598

  5. Stefan Bürk commented on patch set 2 CR -1 06/14/23, 19:56

    on it
  6. Stefan Bürk uploaded patch set 3 CR -1 V +1 06/14/23, 19:58

  7. core-ci voted on patch set 3 V +1 06/14/23, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42600

  8. Oliver Klee voted on patch set 3 V +1 CR +1 06/14/23, 20:07

  9. Anja Leichsenring updated the commit message in patch set 4 CR +1 V +1 06/14/23, 20:09

  10. Anja Leichsenring voted on patch set 4 V +1 CR +1 06/14/23, 20:10

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 06/14/23, 20:10

  12. core-ci voted on patch set 4 V +1 06/14/23, 20:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42601

  13. Stefan Bürk voted on patch set 4 V +2 CR +2 06/14/23, 20:43

  14. Stefan Bürk merged patch set 5 06/14/23, 20:43