Review main Merged Breaking

79385[!!!][TASK] Remove deprecated `CompositeExpression` methods

Stefan Bürk CR +2 V +2 Normal +16 −77 updated 06/14/23, 21:54

Commit message

Removes deprecations from class
`\TYPO3\CMS\Core\Database\Query\Expression\CompositeExpression`:

* `CompositeExpression->add()`
* `CompositeExpression->addMultiple()`

Additionally, the constructor is cleaned and set to @internal
to match doctrine/dbal 4.x immutable design.

Note: If removed methods are called, the would call
      the parent methods. They will be removed with
      the raise to doctrine/dbal 4.x.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 4

Files 3

Review log 812

  1. Stefan Bürk uploaded patch set 1 06/14/23, 20:45

  2. Stefan Bürk updated the commit message in patch set 2 06/14/23, 20:47

  3. Stefan Bürk uploaded patch set 3 06/14/23, 20:48

  4. core-ci voted on patch set 1 V +1 06/14/23, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42603

  5. core-ci voted on patch set 2 V +1 06/14/23, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42604

  6. core-ci voted on patch set 3 V +1 06/14/23, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42605

  7. Christian Kuhn updated the commit message in patch set 4 V +1 06/14/23, 21:01

  8. Christian Kuhn voted on patch set 4 V +1 CR +1 06/14/23, 21:02

  9. core-ci voted on patch set 4 V +1 06/14/23, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42608

  10. Benni Mack voted on patch set 4 V +1 CR +1 06/14/23, 21:53

  11. Stefan Bürk voted on patch set 4 V +2 CR +2 06/14/23, 21:54

  12. Stefan Bürk merged patch set 5 06/14/23, 21:54