Review main Merged Breaking

79396[!!!][TASK] Remove deprecated code in BackendUtility

Thomas Hohn CR +2 V +2 Normal +8 −102 updated 06/15/23, 14:51

Commit message

Removed the following public methods in the class
\TYPO3\CMS\Backend\Utility\BackendUtility
* getClickMenuOnIconTagParameters
* getUpdateSignalCode

In addition removed usage of `JScode`

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 1520

  1. Thomas Hohn uploaded patch set 1 06/15/23, 06:13

  2. core-ci voted on patch set 1 V -1 06/15/23, 06:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42632

  3. Thomas Hohn uploaded patch set 2 V -1 06/15/23, 06:37

  4. core-ci voted on patch set 2 V +1 06/15/23, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42636

  5. Oliver Klee voted on patch set 2 V +1 06/15/23, 07:07

  6. Oliver Klee voted on patch set 2 CR +1 06/15/23, 07:22

  7. Thomas Hohn uploaded patch set 3 CR +1 V +1 06/15/23, 10:41

  8. Thomas Hohn uploaded patch set 4 06/15/23, 10:42

  9. core-ci voted on patch set 3 V +1 06/15/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42651

  10. core-ci voted on patch set 4 V +1 06/15/23, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42652

  11. Oliver Klee commented on patch set 4 06/15/23, 11:58

    There's an "in" or "from" missing after "code".
  12. Thomas Hohn uploaded patch set 5 V +1 06/15/23, 12:49

  13. Thomas Hohn commented on patch set 5 06/15/23, 12:49

    Reply

    Done
  14. Oliver Klee voted on patch set 5 V +1 CR +1 06/15/23, 12:56

  15. core-ci voted on patch set 5 V +1 06/15/23, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42659

  16. Stefan Bürk voted on patch set 5 V +2 CR +2 06/15/23, 13:24

  17. Stefan Bürk merged patch set 6 06/15/23, 13:24

  18. Benni Mack commented on patch set 6 06/15/23, 14:17

    BackendUtility.php:2015

    you removed a hook here, needs to be mentioned in the RST
  19. Thomas Hohn commented on patch set 6 06/15/23, 14:30

    BackendUtility.php:2015 Reply

    Hi will - make a drive by patch for that - good catch :-)
  20. Thomas Hohn commented on patch set 6 06/15/23, 14:51

    BackendUtility.php:2015 Reply Unresolved

    Hi Benny - had a second look at I - the hook is still used and evaluated in the getUpdateSignalDetails method - so there should be no need to mentioning this change?