Review main Merged

79398[TASK] Make "Show sys_log entries" non-schedulable

Sybille Peters CR +2 V +2 Easy +1 −0 updated 06/15/23, 22:15

Commit message

The command "Show entries from sys_log database" (syslog:list)
should not be schedulable because it is an output only
command and no output will be displayed in scheduler.

Also, no output is displayed if a scheduler task is
created for it and this is run from the shell.

The command is now no longer schedulable and is not
available as scheduler task.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Sybille Peters uploaded patch set 1 06/15/23, 06:20

  2. core-ci voted on patch set 1 V +1 06/15/23, 06:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42634

  3. Chris Müller updated the commit message in patch set 2 V +1 06/15/23, 18:42

  4. Chris Müller voted on patch set 2 CR +1 06/15/23, 18:43

  5. core-ci voted on patch set 2 V +1 06/15/23, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42673

  6. Oliver Klee voted on patch set 2 CR +1 06/15/23, 18:54

  7. Benni Mack updated the commit message in patch set 3 CR +1 V +1 06/15/23, 20:01

  8. Oliver Klee voted on patch set 3 CR +1 06/15/23, 20:02

  9. core-ci voted on patch set 3 V +1 06/15/23, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42684

  10. Benni Mack voted on patch set 3 V +1 CR +1 06/15/23, 22:02

  11. Stefan Bürk voted on patch set 3 V +2 CR +2 06/15/23, 22:14

  12. Stefan Bürk merged patch set 4 06/15/23, 22:15