Review main Merged Breaking

79401[!!!][TASK] Remove workaround to make f:format.html work in BE context

Nikita Hovratov CR +2 V +2 Normal +27 −38 updated 06/15/23, 10:55

Commit message

Remove hacky workaround of loading TSFE into the BE context. An
exception is now thrown, if this ViewHelper is invoked in BE context.
Since TYPO3 v11 there are many alternatives: f:sanitize.html,
f:transform.html or even f:format.raw.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1013

  1. Nikita Hovratov uploaded patch set 1 06/15/23, 07:59

  2. Nikita Hovratov uploaded patch set 2 06/15/23, 08:03

  3. core-ci voted on patch set 1 V +1 06/15/23, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42643

  4. Thomas Hohn voted on patch set 2 CR +1 06/15/23, 08:10

  5. Oliver Klee commented on patch set 2 06/15/23, 08:15

    I propose adding a test for the exception.
  6. core-ci voted on patch set 2 V +1 06/15/23, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42644

  7. Nikita Hovratov uploaded patch set 3 CR +1 V +1 06/15/23, 08:36

  8. Nikita Hovratov commented on patch set 3 06/15/23, 08:36

    Reply

    Done.
  9. core-ci voted on patch set 3 V +1 06/15/23, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42648

  10. Oliver Klee voted on patch set 3 V +1 CR +1 06/15/23, 08:59

  11. Benni Mack voted on patch set 3 V +1 CR +1 06/15/23, 10:28

  12. Nikita Hovratov voted on patch set 3 V +2 CR +2 06/15/23, 10:55

  13. Nikita Hovratov merged patch set 4 06/15/23, 10:55