Review main Merged Breaking

79403[!!!][TASK] Remove deprecated 'requireJsModules'

Thomas Hohn CR +2 V +2 Hard +18 −250 updated 06/15/23, 20:05

Commit message

Removed the following public methods:
* \TYPO3\CMS\Core\Page\JavaScriptModuleInstruction->shallLoadRequireJs
* \TYPO3\CMS\Core\Page\PageRenderer->loadRequireJsModule
* \TYPO3\CMS\Core\Page\JavaScriptModuleInstruction::forRequireJS
* \TYPO3\CMS\Setup\Event\AddJavaScriptModulesEvent->addModule
* \TYPO3\CMS\Setup\Event\AddJavaScriptModulesEvent->getModules

Removed the following public constants:
* \TYPO3\CMS\Core\Page\JavaScriptModuleInstruction::FLAG_LOAD_REQUIRE_JS

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 6

Files 18

Review log 1622

  1. Thomas Hohn uploaded patch set 1 06/15/23, 08:09

  2. core-ci voted on patch set 1 V +1 06/15/23, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42646

  3. Thomas Hohn uploaded patch set 2 V +1 06/15/23, 08:16

  4. core-ci voted on patch set 2 V +1 06/15/23, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42647

  5. Thomas Hohn uploaded patch set 3 V +1 06/15/23, 10:47

  6. core-ci voted on patch set 3 V +1 06/15/23, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42653

  7. Thomas Hohn uploaded patch set 4 V +1 06/15/23, 13:35

  8. core-ci voted on patch set 4 V +1 06/15/23, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42661

  9. Benni Mack commented on patch set 4 06/15/23, 16:03

    SetupModuleController.php:166

    I think we can get rid of the getModules in the Event as well
  10. Thomas Hohn commented on patch set 4 06/15/23, 16:19

    SetupModuleController.php:166 Reply

    Can we just remove it when it's public?
  11. Benni Mack commented on patch set 4 06/15/23, 18:29

    SetupModuleController.php:166 Reply

    if you remove addModule() then getModules() is always empty. In general, ext authors would use addModule() - which you can remove, then getModules() can just vanish. We do not have requireJS modules anymore, which is the purpose of getModules and addModules(). This deprecation should have been handled differently, but it's ok to remove both methods on the event now. Plus, the event isn't that critical - it only resides in EXT:setup - it's not within TSFE or FAL ;)
  12. Thomas Hohn uploaded patch set 5 V +1 06/15/23, 19:09

  13. Thomas Hohn commented on patch set 5 06/15/23, 19:11

    SetupModuleController.php:166 Reply

    Done
  14. core-ci voted on patch set 5 V -1 06/15/23, 19:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42677

  15. Oliver Klee commented on patch set 5 06/15/23, 19:24

    AddJavaScriptModulesEvent.php:33

    We then should remove this property as well. (That’s what PHPStan currently is complaining about.)
  16. Thomas Hohn commented on patch set 5 CR +1 06/15/23, 19:30

    AddJavaScriptModulesEvent.php:33 Reply

    Ack
  17. Thomas Hohn uploaded patch set 6 CR +1 V -1 06/15/23, 19:30

  18. core-ci voted on patch set 6 V +1 06/15/23, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42680

  19. Benni Mack voted on patch set 6 V +1 CR +1 06/15/23, 19:57

  20. Oliver Klee voted on patch set 6 V +1 CR +1 06/15/23, 20:00

  21. Benni Mack voted on patch set 6 V +2 CR +2 06/15/23, 20:05

  22. Benni Mack merged patch set 7 06/15/23, 20:05