79403[!!!][TASK] Remove deprecated 'requireJsModules'
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 6
- Task #101067Remove deprecated 'requireJsModules'
- Epic #100963Removal of deprecated code planned to be removed in TYPO3 v13.0
- Task #95200Streamline requireJS usage in FormEngine
- Task #97057Deprecate RequireJS related APIs
- Task #96221Deny inline JavaScript in FormEngine's requireJsModules
- Feature #98431Support javaScriptModules in FormEngine resultArray
Files 18
- typo3/sysext/backend/Classes/Controller/FormFilesAjaxController.php+0 −2
- typo3/sysext/backend/Classes/Controller/FormFlexAjaxController.php+0 −2
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+0 −2
- typo3/sysext/backend/Classes/Controller/SiteInlineAjaxController.php+0 −2
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+5 −16
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+0 −2
- typo3/sysext/backend/Classes/Form/AbstractNode.php+1 −9
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+0 −27
- typo3/sysext/backend/Tests/Unit/Form/NodeExpansion/FieldControlTest.php+0 −2
- typo3/sysext/core/Classes/Page/JavaScriptModuleInstruction.php+0 −29
- typo3/sysext/core/Classes/Page/JavaScriptRenderer.php+2 −17
- typo3/sysext/core/Classes/Page/PageRenderer.php+0 −56
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-100963-DeprecatedFunctionalityRemoved.rst+7 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageRendererViewHelper.php+0 −5
- typo3/sysext/form/Classes/Controller/FormEditorController.php+2 −32
- typo3/sysext/form/Classes/Controller/FormManagerController.php+1 −18
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php4+0 −4
- typo3/sysext/setup/Classes/Event/AddJavaScriptModulesEvent.php2+0 −25
Review log 1622
-
Thomas Hohn uploaded patch set 1 06/15/23, 08:09
-
core-ci voted on patch set 1 V +1 06/15/23, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42646
-
Thomas Hohn uploaded patch set 2
V +106/15/23, 08:16 -
core-ci voted on patch set 2 V +1 06/15/23, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42647
-
Thomas Hohn uploaded patch set 3
V +106/15/23, 10:47 -
core-ci voted on patch set 3 V +1 06/15/23, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42653
-
Thomas Hohn uploaded patch set 4
V +106/15/23, 13:35 -
core-ci voted on patch set 4 V +1 06/15/23, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42661
-
Benni Mack commented on patch set 4 06/15/23, 16:03
-
Thomas Hohn commented on patch set 4 06/15/23, 16:19
SetupModuleController.php:166ReplyCan we just remove it when it's public? -
Benni Mack commented on patch set 4 06/15/23, 18:29
SetupModuleController.php:166Replyif you remove addModule() then getModules() is always empty. In general, ext authors would use addModule() - which you can remove, then getModules() can just vanish. We do not have requireJS modules anymore, which is the purpose of getModules and addModules(). This deprecation should have been handled differently, but it's ok to remove both methods on the event now. Plus, the event isn't that critical - it only resides in EXT:setup - it's not within TSFE or FAL ;) -
Thomas Hohn uploaded patch set 5
V +106/15/23, 19:09 -
Thomas Hohn commented on patch set 5 06/15/23, 19:11
SetupModuleController.php:166ReplyDone -
core-ci voted on patch set 5 V -1 06/15/23, 19:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42677
-
Oliver Klee commented on patch set 5 06/15/23, 19:24
AddJavaScriptModulesEvent.php:33We then should remove this property as well. (That’s what PHPStan currently is complaining about.) -
Thomas Hohn commented on patch set 5 CR +1 06/15/23, 19:30
AddJavaScriptModulesEvent.php:33ReplyAck -
Thomas Hohn uploaded patch set 6
CR +1V -106/15/23, 19:30 -
core-ci voted on patch set 6 V +1 06/15/23, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42680
-
Benni Mack voted on patch set 6 V +1 CR +1 06/15/23, 19:57
-
Oliver Klee voted on patch set 6 V +1 CR +1 06/15/23, 20:00
-
Benni Mack voted on patch set 6 V +2 CR +2 06/15/23, 20:05
-
Benni Mack merged patch set 7 06/15/23, 20:05
SetupModuleController.php:166