Review main Merged Breaking

79405[!!!][TASK] Remove obsolete class UserFileMountService

Thomas Hohn CR +2 V +2 Normal +2 −147 updated 06/15/23, 15:11

Commit message

Removed the following public class:
* \TYPO3\CMS\Core\Resource\Service\UserFileMountService

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 1012

  1. Thomas Hohn uploaded patch set 1 06/15/23, 13:53

  2. core-ci voted on patch set 1 V -1 06/15/23, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42662

  3. Oliver Klee voted on patch set 1 CR +1 06/15/23, 14:05

  4. Oliver Klee commented on patch set 1 CR 0 06/15/23, 14:05

    We‘ll need to rebuild the PHPStan baseline as we’ve now removed a warning.
  5. Thomas Hohn uploaded patch set 2 V -1 06/15/23, 14:30

  6. Thomas Hohn commented on patch set 2 06/15/23, 14:31

    Reply

    Done
  7. Oliver Klee voted on patch set 2 CR +1 06/15/23, 14:32

  8. core-ci voted on patch set 2 V +1 06/15/23, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42665

  9. Oliver Klee voted on patch set 2 V +1 06/15/23, 14:57

  10. Stefan Bürk voted on patch set 2 CR +1 06/15/23, 15:04

  11. Stefan Bürk voted on patch set 2 V +2 CR +2 06/15/23, 15:11

  12. Stefan Bürk merged patch set 3 06/15/23, 15:11