Review main Abandoned Breaking

79407[WIP][!!!][TASK] Always enable TYPO3_CONF_VARS[FE][cacheHash][enforceValidation]

Benni Mack CR 0 V 0 Normal +5 −133 updated 06/21/23, 09:20

Commit message

@todo: We need to revise what other cacheHash options are dropped

$GLOBALS['TYPO3_CONF_VARS']['FE']['cacheHash']['requireCacheHashPresenceParameters']
is now always enabled

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 22

Show 2 more files

Review log 45

  1. Benni Mack uploaded patch set 1 06/15/23, 16:01

  2. core-ci voted on patch set 1 V -1 06/15/23, 16:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42670

  3. Chris Müller commented on patch set 1 06/16/23, 08:04

    I am not sure that it is good to always enable it: I activated it on v11 and had then 404 pages where some advertising get parameters were set from paid ads (I haven't known of). That was bad. So I deactivated this option again.
  4. Benni Mack commented on patch set 1 06/16/23, 22:29

    Reply Unresolved

    thanks for the hint. We need to update the list of the excluded parameters then.
  5. Benni Mack abandoned the change 06/21/23, 09:20

    not handled for the time being then