79407[WIP][!!!][TASK] Always enable TYPO3_CONF_VARS[FE][cacheHash][enforceValidation]
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 22
- typo3/sysext/core/Configuration/DefaultConfiguration.php+0 −2
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+0 −6
- typo3/sysext/core/Configuration/FactoryConfiguration.php+0 −3
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-100963-DeprecatedFunctionalityRemoved.rst+2 −0
- typo3/sysext/fluid/Tests/Functional/View/TemplatesPathsTest.php+0 −5
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/TypolinkViewHelperTest.php+0 −8
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/TypolinkViewHelperTest.php+0 −8
- typo3/sysext/frontend/Classes/Middleware/PageArgumentValidator.php+1 −28
- typo3/sysext/frontend/Classes/Page/CacheHashCalculator.php+0 −24
- typo3/sysext/frontend/Classes/Page/CacheHashConfiguration.php+0 −3
- typo3/sysext/frontend/Tests/Functional/Rendering/TitleTagRenderingTest.php+0 −8
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+0 −3
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+0 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteWithoutRequiredCHashRequestTest.php+0 −3
- typo3/sysext/frontend/Tests/Unit/Page/CacheHashCalculatorTest.php+0 −1
- typo3/sysext/frontend/Tests/Unit/Page/CacheHashConfigurationTest.php+0 −6
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+2 −0
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+0 −2
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesTest.php+0 −8
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapPagesWithHideIfNotTranslatedTest.php+0 −3
Review log 45
-
Benni Mack uploaded patch set 1 06/15/23, 16:01
-
core-ci voted on patch set 1 V -1 06/15/23, 16:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42670
-
Chris Müller commented on patch set 1 06/16/23, 08:04
I am not sure that it is good to always enable it: I activated it on v11 and had then 404 pages where some advertising get parameters were set from paid ads (I haven't known of). That was bad. So I deactivated this option again. -
Benni Mack commented on patch set 1 06/16/23, 22:29
Reply Unresolved
thanks for the hint. We need to update the list of the excluded parameters then. -
Benni Mack abandoned the change 06/21/23, 09:20
not handled for the time being then