Review main Merged

79408[BUGFIX] Enable client side min/max validation for type folder

Nikita Hovratov CR +2 V +2 Easy +3 −2 updated 06/22/23, 17:59

Commit message

While separating type folder from type group, it was forgotten to enable
client-side validation for min/max checks in the FormEngine validation.

Furthermore, it is recommended to use minitems over required=true for
fields with multiple items. Reasons are: 1. it is not documented, 2.
to better conform with the counterpart option maxitems.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 78

  1. Nikita Hovratov uploaded patch set 1 06/15/23, 16:07

  2. core-ci voted on patch set 1 V +1 06/15/23, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42671

  3. Oliver Klee voted on patch set 1 CR +1 06/15/23, 16:33

  4. Benni Mack voted on patch set 1 CR +1 06/15/23, 20:47

  5. Andreas Kienast voted on patch set 1 CR +1 06/16/23, 13:07

  6. Christian Kuhn voted on patch set 1 V +1 CR +1 06/22/23, 17:42

  7. Nikita Hovratov commented on patch set 1 V +2 CR +2 06/22/23, 17:59

    Merging with one missing verified vote. Reason: nobrainer
  8. Nikita Hovratov merged patch set 2 06/22/23, 17:59