Review main Merged Breaking

79409[!!!][TASK] Require second argument on FormDataCompiler->compile

Christian Kuhn CR +2 V +2 Normal +78 −79 updated 06/15/23, 22:20

Commit message

Remove custom constructor and require second
argument on FormDataCompiler->compile() instead.
This makes FormDataCompiler injectable, which is
now used in various controllers.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 15

Review log 56

  1. Christian Kuhn uploaded patch set 1 06/15/23, 21:45

  2. core-ci voted on patch set 1 V +1 06/15/23, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42696

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 06/15/23, 22:14

  4. Benni Mack voted on patch set 1 V +1 CR +1 06/15/23, 22:16

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 06/15/23, 22:20

  6. Christian Kuhn merged patch set 2 06/15/23, 22:20