Review main Merged Breaking

79411[!!!][TASK] Require current request in FormDataCompiler

Christian Kuhn CR +2 V +2 Easy +20 −5 updated 06/16/23, 09:09

Commit message

Fallback to $GLOBALS['TYPO3_REQUEST'] removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1113

  1. Christian Kuhn uploaded patch set 1 06/15/23, 22:26

  2. core-ci voted on patch set 1 V +1 06/15/23, 22:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42703

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 06/15/23, 22:35

  4. Thomas Hohn voted on patch set 1 CR +1 06/16/23, 06:55

  5. Oliver Klee commented on patch set 1 06/16/23, 07:26

    FormDataCompiler.php:73

    Please let’s cover throwing the exception with a test.
  6. Nikita Hovratov uploaded patch set 2 CR +1 V +1 06/16/23, 07:56

  7. Nikita Hovratov commented on patch set 2 06/16/23, 07:56

    FormDataCompiler.php:73 Reply

    Done
  8. Nikita Hovratov voted on patch set 2 V +1 CR +1 06/16/23, 07:57

  9. Oliver Klee voted on patch set 2 CR +1 06/16/23, 08:02

  10. core-ci voted on patch set 2 V +1 06/16/23, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42720

  11. Oliver Klee voted on patch set 2 V +1 06/16/23, 08:06

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 06/16/23, 09:09

  13. Christian Kuhn merged patch set 3 06/16/23, 09:09