79434[!!!][TASK] Remove deprecated code in PasswordChangeEvent
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 3
Files 4
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-100963-DeprecatedFunctionalityRemoved.rst+3 −0
- typo3/sysext/felogin/Classes/Controller/PasswordRecoveryController.php6+0 −14
- typo3/sysext/felogin/Classes/Event/PasswordChangeEvent.php2+2 −56
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+3 −0
Review log 1824
-
Thomas Hohn uploaded patch set 1 06/16/23, 05:34
-
core-ci voted on patch set 1 V -1 06/16/23, 05:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42712
-
Thomas Hohn uploaded patch set 2
V -106/16/23, 05:54 -
core-ci voted on patch set 2 V +1 06/16/23, 06:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42714
-
Torben Hansen commented on patch set 2 06/16/23, 06:30
PasswordChangeEvent.php:25This can be removed too together with `isPropagationStopped`. -
Thomas Hohn uploaded patch set 3
V +106/16/23, 06:48 -
Thomas Hohn commented on patch set 3 06/16/23, 06:48
PasswordRecoveryController.php:329ReplyHowever that will impose a problem with the return value - which is return $hashedPassword;PasswordChangeEvent.php:25ReplyDone -
Torben Hansen commented on patch set 3 06/16/23, 06:53
PasswordRecoveryController.php:329Reply`$hashedPassword` is already passed as parameter to the method. The event now has no possibility to modify it any more, so we do not really require to retrieve it from the event. -
core-ci voted on patch set 3 V +1 06/16/23, 06:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42715
-
Thomas Hohn commented on patch set 3 CR +1 06/16/23, 10:43
PasswordRecoveryController.php:329ReplyHi - signature is @return ForwardResponse|string - what would jo return then? Empty string? -
Torben Hansen commented on patch set 3 06/17/23, 07:18
PasswordRecoveryController.php:329ReplyIt should stay `ForwardResponse|string`. Note, that the function parameter `$hashedPassword` will already include the hashed password. The event did previously just offer the possibility to change the hash. Now the event is informal only. -
Thomas Hohn uploaded patch set 4
CR +1V +106/17/23, 07:33 -
core-ci voted on patch set 4 V +1 06/17/23, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42773
-
Oliver Klee commented on patch set 4 06/17/23, 08:03
PasswordRecoveryController.php:329ReplyDone -
Oliver Klee voted on patch set 4 V +1 CR +1 06/17/23, 08:04
-
Torben Hansen voted on patch set 4 V +1 CR +1 06/19/23, 08:24
-
Benni Mack updated the commit message in patch set 5
CR +1V +106/19/23, 09:43 -
Benni Mack commented on patch set 6 06/19/23, 09:44
Published edit on patch set 5. -
core-ci voted on patch set 6 V +1 06/19/23, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42805
-
core-ci voted on patch set 5 V +1 06/19/23, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42804
-
Benni Mack voted on patch set 6 V +1 CR +1 06/19/23, 09:55
-
Oliver Klee voted on patch set 6 V +1 CR +1 06/19/23, 10:24
-
Benni Mack voted on patch set 6 V +2 CR +2 06/19/23, 11:04
-
Benni Mack merged patch set 7 06/19/23, 11:04
PasswordRecoveryController.php:329