Review main Merged Breaking

79434[!!!][TASK] Remove deprecated code in PasswordChangeEvent

Thomas Hohn CR +2 V +2 Normal +8 −70 updated 06/19/23, 11:04

Commit message

Removed the following public methods:
* \TYPO3\CMS\FrontendLogin\Event\PasswordChangeEvent->setAsInvalid
* \TYPO3\CMS\FrontendLogin\Event\PasswordChangeEvent->setHashedPassword
* \TYPO3\CMS\FrontendLogin\Event\PasswordChangeEvent->getErrorMessage

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 1824

  1. Thomas Hohn uploaded patch set 1 06/16/23, 05:34

  2. core-ci voted on patch set 1 V -1 06/16/23, 05:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42712

  3. Thomas Hohn uploaded patch set 2 V -1 06/16/23, 05:54

  4. core-ci voted on patch set 2 V +1 06/16/23, 06:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42714

  5. Torben Hansen commented on patch set 2 06/16/23, 06:30

    PasswordRecoveryController.php:329

    This line can also be removed, since it is not possible any more to change the value in the event.

    PasswordChangeEvent.php:25

    This can be removed too together with `isPropagationStopped`.
  6. Thomas Hohn uploaded patch set 3 V +1 06/16/23, 06:48

  7. Thomas Hohn commented on patch set 3 06/16/23, 06:48

    PasswordRecoveryController.php:329 Reply

    However that will impose a problem with the return value - which is return $hashedPassword;

    PasswordChangeEvent.php:25 Reply

    Done
  8. Torben Hansen commented on patch set 3 06/16/23, 06:53

    PasswordRecoveryController.php:329 Reply

    `$hashedPassword` is already passed as parameter to the method. The event now has no possibility to modify it any more, so we do not really require to retrieve it from the event.
  9. core-ci voted on patch set 3 V +1 06/16/23, 06:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42715

  10. Thomas Hohn commented on patch set 3 CR +1 06/16/23, 10:43

    PasswordRecoveryController.php:329 Reply

    Hi - signature is @return ForwardResponse|string - what would jo return then? Empty string?
  11. Torben Hansen commented on patch set 3 06/17/23, 07:18

    PasswordRecoveryController.php:329 Reply

    It should stay `ForwardResponse|string`. Note, that the function parameter `$hashedPassword` will already include the hashed password. The event did previously just offer the possibility to change the hash. Now the event is informal only.
  12. Thomas Hohn uploaded patch set 4 CR +1 V +1 06/17/23, 07:33

  13. core-ci voted on patch set 4 V +1 06/17/23, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42773

  14. Oliver Klee commented on patch set 4 06/17/23, 08:03

    PasswordRecoveryController.php:329 Reply

    Done
  15. Oliver Klee voted on patch set 4 V +1 CR +1 06/17/23, 08:04

  16. Torben Hansen voted on patch set 4 V +1 CR +1 06/19/23, 08:24

  17. Benni Mack updated the commit message in patch set 5 CR +1 V +1 06/19/23, 09:43

  18. Benni Mack commented on patch set 6 06/19/23, 09:44

    Published edit on patch set 5.
  19. core-ci voted on patch set 6 V +1 06/19/23, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42805

  20. core-ci voted on patch set 5 V +1 06/19/23, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42804

  21. Benni Mack voted on patch set 6 V +1 CR +1 06/19/23, 09:55

  22. Oliver Klee voted on patch set 6 V +1 CR +1 06/19/23, 10:24

  23. Benni Mack voted on patch set 6 V +2 CR +2 06/19/23, 11:04

  24. Benni Mack merged patch set 7 06/19/23, 11:04