79438[!!!][TASK] Remove deprecated code in LocalizationUtility
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 3
Files 5
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-100963-DeprecatedFunctionalityRemoved.rst+2 −0
- typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php8+7 −21
- typo3/sysext/extbase/Tests/Functional/Utility/LocalizationUtilityTest.php+5 −7
- typo3/sysext/extbase/Tests/FunctionalDeprecated/Utility/LocalizationUtilityTest.phpdeleted+0 −108
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php+1 −3
Review log 3143
Show 1218 earlier messages
-
Thomas Hohn uploaded patch set 1 06/16/23, 07:46
-
Benni Mack commented on patch set 1 06/16/23, 07:54
-
core-ci voted on patch set 1 V -1 06/16/23, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42719
-
Thomas Hohn commented on patch set 1 06/16/23, 08:09
LocalizationUtility.php:80ReplyAck -
Thomas Hohn uploaded patch set 2
V -106/16/23, 08:25 -
Oliver Klee updated the commit message in patch set 3 06/16/23, 08:26
-
Oliver Klee commented on patch set 3 06/16/23, 08:28
LocalizationUtility.php:108In general, there is no need to add PHPDoc that only repeats what we already have as native type declarations. -
Thomas Hohn commented on patch set 3 06/16/23, 08:30
LocalizationUtility.php:108ReplySo just remove it in both places (initializeLocalization and buildLanguageService) -
Benni Mack commented on patch set 3 06/16/23, 08:32
LocalizationUtility.php:108ReplyYes -
core-ci voted on patch set 2 V -1 06/16/23, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42725
-
core-ci voted on patch set 3 V -1 06/16/23, 08:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42726
-
Thomas Hohn uploaded patch set 4
V -106/16/23, 08:40 -
Thomas Hohn uploaded patch set 5 06/16/23, 08:49
-
core-ci voted on patch set 4 V -1 06/16/23, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42727
-
core-ci voted on patch set 5 V -1 06/16/23, 08:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42728
-
Thomas Hohn uploaded patch set 6
V -106/16/23, 10:37 -
core-ci voted on patch set 6 V -1 06/16/23, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42733
-
Oliver Klee commented on patch set 6 06/16/23, 10:52
LocalizationUtility.php:108ReplyDone
-
Benni Mack commented on patch set 6 06/16/23, 13:51
LocalizationUtility.php:79you need to remove "null" here, as the method initializeLocalization() only has three arguments now -
Thomas Hohn uploaded patch set 7
V -106/16/23, 15:22 -
core-ci voted on patch set 7 V -1 06/16/23, 15:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42744
-
Oliver Klee commented on patch set 7 06/16/23, 15:37
phpstan-baseline.neon:1599We'll need to undo this change (e.g., by using the file from the main branch, or by regenerating the baseline file) as this warning now does not exist anymore.LocalizationUtility.php:79ReplyDone -
Thomas Hohn uploaded patch set 8
V -106/16/23, 16:25 -
core-ci voted on patch set 8 V +1 06/16/23, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42746
-
Thomas Hohn commented on patch set 8 06/16/23, 16:34
phpstan-baseline.neon:1599ReplyRegenerated -
Thomas Hohn commented on patch set 8 06/16/23, 16:48
phpstan-baseline.neon:1599ReplyDone -
Stefan Bürk voted on patch set 8 CR -1 06/16/23, 17:09
-
Stefan Bürk commented on patch set 8 06/16/23, 17:18
Please leave the deprecated tests in place for now. (Restore them). Even if there are no functional tests left after this patch. We will consider it in a dedicated patch if we comment them out or remove them. It's quite an effort toe reintroduce a ci matrix with them if the next deprecation patch moves a test to a deprecation folder. Granted, will be some unneeded jobs for now. Removing the config and the runTest.sh suite is not needed at all. That should stay for manual execution. -
Oliver Klee commented on patch set 8 06/16/23, 17:20
Reply
Then we'll need a dummy functional test (which I recommend we do in a pre-patch). Otherwise (with the deprecated functional test setup in place, but not tests there), the build fails. (This is what happened in this change in an earlier changeset.) -
Oliver Klee commented on patch set 8 06/16/23, 17:22
(In general, I would have been glad to take care of adding the dummy test. At the moment though, I'm super-busy preparing a workshop, and hence would prefer that someone else took care of that.) -
Thomas Hohn uploaded patch set 9
CR -1V +106/16/23, 18:10 -
core-ci voted on patch set 9 V -1 06/16/23, 18:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42749
-
Thomas Hohn uploaded patch set 10
V -106/16/23, 18:23 -
core-ci voted on patch set 10 V -1 06/16/23, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42750
-
Thomas Hohn uploaded patch set 11
V -106/16/23, 18:32 -
core-ci voted on patch set 11 V +1 06/16/23, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42751
-
Thomas Hohn uploaded patch set 12
V +106/16/23, 19:16 -
Thomas Hohn commented on patch set 11 06/16/23, 19:16
Reply
Dummy tests created 😊 -
core-ci voted on patch set 12 V +1 06/16/23, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42754
-
Oliver Klee voted on patch set 12 V +1 CR +1 06/16/23, 19:37
-
Benni Mack voted on patch set 12 V +2 CR +2 06/16/23, 22:10
-
Benni Mack merged patch set 13 06/16/23, 22:10
LocalizationUtility.php:80