Review main Merged

79440[BUGFIX] Reduce size of prepared statements in DatabaseIntegrityCheck

Krzysztof Gutkowski CR +2 V +2 Easy +27 −19 updated 06/20/23, 05:15

Commit message

The code checking for missing relations would perform the query with all
potential missing relation uids for a given table, which, given a large
enough table, would exceed the prepared statement placeholder limit for
the database connection.

This commit makes the relevant function process the checked relation
uids in chunks no larger than the placeholder limit.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Krzysztof Gutkowski uploaded patch set 1 06/16/23, 09:40

  2. core-ci voted on patch set 1 V +1 06/16/23, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42730

  3. Benni Mack voted on patch set 1 V +1 CR +1 06/16/23, 13:55

  4. Stefan Bürk voted on patch set 1 V +2 CR +2 06/20/23, 05:15

  5. Stefan Bürk merged patch set 2 06/20/23, 05:15