Review main Abandoned

79441[TASK] Respect TCA overrides for CE localization

TYPO3com CR 0 V 0 Easy +11 −1 updated 07/12/23, 08:14

Commit message

I have a few general purpose columns, that are shared between CTypes. The
implementation differs between them, and is setup via overrides for the
specific CType.

DataHandler->localize doesn't seem to respect column overrides for CTypes,
resulting in settings like `l10n_mode` being ignored, if they are set via
CType specific override.

The scenario where I ran into this, was trying to translate one of the
general purpose columns via
https://github.com/web-vision/wv_deepltranslate/. The columns were
ignored, because it didn't detect the `'l10n_mode' => 'prefixLangTitle'`,
which had to be set via overrides in my case.

This pull request adds the handling of CType specific overrides in
DataHandler->localize.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 68

  1. TYPO3com uploaded patch set 1 06/16/23, 10:00

  2. core-ci voted on patch set 1 V -1 06/16/23, 10:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42731

  3. Benni Mack wrote 07/10/23, 18:49

    Change destination moved from 11.5 to main
  4. Oli Bartsch commented on patch set 1 V -1 07/11/23, 08:11

    DataHandler should not consider columnsOverrides. This setting is for display purposes only. See corresponding documentation: https://docs.typo3.org/m/typo3/reference-tca/main/en-us/Types/Properties/ColumnsOverrides.html
  5. kauz 56 commented on patch set 1 07/11/23, 13:11

    Reply

    Thank you for the feedback. I've noticed this issue in other places in DataHandler aswell in the meantime. This explains it then. One question however, if you don't mind: Is it really "should not consider" or is it "does not consider"? In the docs it says: "Currently, it only affects the display of form fields, but not the data handling.". The "currently" suggests to me, that this isn't entirely by design perhaps. Can you consider adding this feature to data handling sometime in the future?
  6. Oli Bartsch commented on patch set 1 07/12/23, 07:40

    Reply

    It is "does not consider". This is the current state, which is intended. I personally don't see any reason for changing this in the future. The "columnsOverrides" option was introduced for display purposes in the form engine and was never intended to influence any data modifications. However, this is just my personal opinion. Feel free to create a feature request on https://forge.typo3.org/, explaining possible use-cases. If you don't mind, I would abandon this patch for now.
  7. kauz 56 commented on patch set 1 07/12/23, 08:08

    Reply Unresolved

    I will go the feature request route and try my luck that way then. So this patch can be abandoned, as you've said already. Thanks again!
  8. Oli Bartsch abandoned the change 07/12/23, 08:14

    has to be implemented as feature