Review main Merged Breaking

79442[!!!][TASK] Enforce DI aware nodes in FormEngine

Christian Kuhn CR +2 V +2 Expert +589 −600 updated 06/20/23, 12:30

Commit message

This makes FormEngine DI ready:
* Activate interface methods
* Have a compiler pass to set NodeInterface classes public
* Adapt interface return values and adapt consuming classses
* Free __construct()
* Use inject* methods in abstracts
* Use DI in FormEngine render classes
* Switch to BackendViewFactory

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 92

Show 72 more files

Review log 1425

  1. Christian Kuhn uploaded patch set 1 06/16/23, 10:47

  2. core-ci voted on patch set 1 V -1 06/16/23, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42734

  3. Christian Kuhn uploaded patch set 2 V -1 06/16/23, 11:48

  4. core-ci voted on patch set 2 V -1 06/16/23, 12:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42738

  5. Christian Kuhn uploaded patch set 3 V -1 06/16/23, 12:20

  6. core-ci voted on patch set 3 V -1 06/16/23, 12:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42739

  7. Benni Mack updated the commit message in patch set 4 V -1 06/16/23, 22:28

  8. core-ci voted on patch set 4 V -1 06/16/23, 22:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42760

  9. Christian Kuhn uploaded patch set 5 V -1 06/19/23, 16:44

  10. core-ci voted on patch set 5 V -1 06/19/23, 16:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42808

  11. Christian Kuhn uploaded patch set 6 V -1 06/19/23, 17:18

  12. core-ci voted on patch set 6 V -1 06/19/23, 17:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42811

  13. Christian Kuhn uploaded patch set 7 V -1 06/19/23, 17:47

  14. core-ci voted on patch set 7 V +1 06/19/23, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42813

  15. Christian Kuhn uploaded patch set 8 V +1 06/20/23, 09:06

  16. core-ci voted on patch set 8 V -1 06/20/23, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42822

  17. Christian Kuhn uploaded patch set 9 V -1 06/20/23, 09:23

  18. core-ci voted on patch set 9 V -1 06/20/23, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42823

  19. Christian Kuhn uploaded patch set 10 V -1 06/20/23, 09:44

  20. core-ci voted on patch set 10 V +1 06/20/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42825

  21. Christian Kuhn uploaded patch set 11 V +1 06/20/23, 10:14

  22. core-ci voted on patch set 11 V +1 06/20/23, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42826

  23. Stefan Bürk voted on patch set 11 V +1 CR +1 06/20/23, 11:31

  24. Benni Mack voted on patch set 11 V +2 CR +2 06/20/23, 12:30

  25. Benni Mack merged patch set 12 06/20/23, 12:30