79442[!!!][TASK] Enforce DI aware nodes in FormEngine
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 3
Files 92
- Build/phpstan/phpstan-baseline.neon+0 −20
- typo3/sysext/backend/Classes/Controller/FormFilesAjaxController.php+3 −3
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+3 −3
- typo3/sysext/backend/Classes/Controller/SiteInlineAjaxController.php+4 −3
- typo3/sysext/backend/Classes/Form/Container/AbstractContainer.php+23 −14
- typo3/sysext/backend/Classes/Form/Container/FileReferenceContainer.php+16 −22
- typo3/sysext/backend/Classes/Form/Container/FilesControlContainer.php+19 −32
- typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php+8 −4
- typo3/sysext/backend/Classes/Form/Container/FlexFormElementContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/FlexFormEntryContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/FlexFormNoTabsContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/FlexFormSectionContainer.php+8 −4
- typo3/sysext/backend/Classes/Form/Container/FlexFormTabsContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/FullRecordContainer.php+1 −2
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+11 −27
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+7 −27
- typo3/sysext/backend/Classes/Form/Container/ListOfFieldsContainer.php+1 −2
- typo3/sysext/backend/Classes/Form/Container/NoTabsContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/OuterWrapContainer.php+8 −11
- typo3/sysext/backend/Classes/Form/Container/PaletteAndSingleContainer.php+3 −5
Show 72 more files
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/SiteLanguageContainer.php+6 −17
- typo3/sysext/backend/Classes/Form/Container/TabsContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+5 −12
- typo3/sysext/backend/Classes/Form/Element/BackendLayoutWizardElement.php+8 −2
- typo3/sysext/backend/Classes/Form/Element/CheckboxElement.php+5 −11
- typo3/sysext/backend/Classes/Form/Element/CheckboxToggleElement.php+0 −1
- typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php+6 −0
- typo3/sysext/backend/Classes/Form/Element/FileInfoElement.php+7 −4
- typo3/sysext/backend/Classes/Form/Element/FolderElement.php+7 −1
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+7 −1
- typo3/sysext/backend/Classes/Form/Element/ImageManipulationElement.php+17 −36
- typo3/sysext/backend/Classes/Form/Element/InputHiddenElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/InputSlugElement.php+7 −1
- typo3/sysext/backend/Classes/Form/Element/LinkElement.php+12 −5
- typo3/sysext/backend/Classes/Form/Element/MfaInfoElement.php+5 −7
- typo3/sysext/backend/Classes/Form/Element/PasswordElement.php+7 −3
- typo3/sysext/backend/Classes/Form/Element/RadioElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+7 −3
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+7 −1
- typo3/sysext/backend/Classes/Form/Element/SelectSingleBoxElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php+8 −4
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/TextTableElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/UnknownElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/UserElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/UserSysFileStorageIsPublicElement.php+8 −3
- typo3/sysext/backend/Classes/Form/Element/UuidElement.php+6 −0
- typo3/sysext/backend/Classes/Form/FieldControl/AddRecord.php+6 −2
- typo3/sysext/backend/Classes/Form/FieldControl/EditPopup.php+7 −3
- typo3/sysext/backend/Classes/Form/FieldControl/ElementBrowser.php+8 −4
- typo3/sysext/backend/Classes/Form/FieldControl/LinkPopup.php+6 −2
- typo3/sysext/backend/Classes/Form/FieldControl/ListModule.php+7 −4
- typo3/sysext/backend/Classes/Form/FieldControl/ResetSelection.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldInformation/BackendLayoutFromParentPage.php+6 −3
- typo3/sysext/backend/Classes/Form/FieldWizard/DefaultLanguageDifferences.php+7 −3
- typo3/sysext/backend/Classes/Form/FieldWizard/OtherLanguageContent.php+7 −3
- typo3/sysext/backend/Classes/Form/FieldWizard/OtherLanguageThumbnails.php+8 −3
- typo3/sysext/backend/Classes/Form/FieldWizard/RecordsOverview.php+6 −2
- typo3/sysext/backend/Classes/Form/FieldWizard/TableList.php+6 −2
- typo3/sysext/backend/Classes/Form/NodeExpansion/FieldControl.php+10 −4
- typo3/sysext/backend/Classes/Form/NodeExpansion/FieldInformation.php+8 −3
- typo3/sysext/backend/Classes/Form/NodeExpansion/FieldWizard.php+8 −3
- typo3/sysext/backend/Classes/Form/AbstractNode.php+1 −24
- typo3/sysext/backend/Classes/Form/InlineStackProcessor.php+1 −1
- typo3/sysext/backend/Classes/Form/NodeFactory.php+15 −19
- typo3/sysext/backend/Classes/Form/NodeInterface.php+3 −8
- typo3/sysext/backend/Classes/Form/NodeResolverInterface.php+2 −5
- typo3/sysext/backend/Configuration/Services.php+4 −0
- typo3/sysext/backend/Configuration/Services.yaml+3 −0
- typo3/sysext/backend/Tests/Functional/Controller/FormInlineAjaxControllerTest.php+5 −0
- typo3/sysext/backend/Tests/Functional/Form/Element/MfaInfoElementTest.phprenamed+7 −8
- typo3/sysext/backend/Tests/Functional/Form/FormTestService.php+6 −1
- typo3/sysext/backend/Tests/Unit/Form/Container/ListOfFieldsContainerTest.php+24 −8
- typo3/sysext/backend/Tests/Unit/Form/Container/PaletteAndSingleContainerTest.php+18 −3
- typo3/sysext/backend/Tests/Unit/Form/Element/DatetimeElementTest.php+5 −3
- typo3/sysext/backend/Tests/Unit/Form/Element/InputHiddenElementTest.php+2 −5
- typo3/sysext/backend/Tests/Unit/Form/Element/JsonElementTest.php+6 −6
- typo3/sysext/backend/Tests/Unit/Form/Element/UuidElementTest.php+14 −13
- typo3/sysext/backend/Tests/Unit/Form/FieldControl/ElementBrowserTest.php+30 −30
- typo3/sysext/backend/Tests/Unit/Form/FieldWizard/TableListTest.php+40 −43
- typo3/sysext/backend/Tests/Unit/Form/Fixtures/NodeFactory/NodeResolvers/BarResolver.php+2 −3
- typo3/sysext/backend/Tests/Unit/Form/Fixtures/NodeFactory/NodeResolvers/FooResolver.php+2 −3
- typo3/sysext/backend/Tests/Unit/Form/Fixtures/NodeFactory/NodeResolvers/InvalidNodeResolverClass.phpdeleted+0 −22
- typo3/sysext/backend/Tests/Unit/Form/NodeExpansion/FieldControlTest.php+5 −5
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php+3 −8
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+3 −8
- typo3/sysext/core/Configuration/Services.yaml+3 −0
- typo3/sysext/core/Documentation/Changelog/12.4/Deprecation-100670-DIAwareFormEngineNodes.rst+4 −4
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-100963-DeprecatedFunctionalityRemoved.rst+4 −0
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+11 −23
- typo3/sysext/rte_ckeditor/Classes/Form/Resolver/RichTextNodeResolver.php+1 −0
Review log 1425
-
Christian Kuhn uploaded patch set 1 06/16/23, 10:47
-
core-ci voted on patch set 1 V -1 06/16/23, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42734
-
Christian Kuhn uploaded patch set 2
V -106/16/23, 11:48 -
core-ci voted on patch set 2 V -1 06/16/23, 12:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42738
-
Christian Kuhn uploaded patch set 3
V -106/16/23, 12:20 -
core-ci voted on patch set 3 V -1 06/16/23, 12:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42739
-
Benni Mack updated the commit message in patch set 4
V -106/16/23, 22:28 -
core-ci voted on patch set 4 V -1 06/16/23, 22:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42760
-
Christian Kuhn uploaded patch set 5
V -106/19/23, 16:44 -
core-ci voted on patch set 5 V -1 06/19/23, 16:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42808
-
Christian Kuhn uploaded patch set 6
V -106/19/23, 17:18 -
core-ci voted on patch set 6 V -1 06/19/23, 17:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42811
-
Christian Kuhn uploaded patch set 7
V -106/19/23, 17:47 -
core-ci voted on patch set 7 V +1 06/19/23, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42813
-
Christian Kuhn uploaded patch set 8
V +106/20/23, 09:06 -
core-ci voted on patch set 8 V -1 06/20/23, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42822
-
Christian Kuhn uploaded patch set 9
V -106/20/23, 09:23 -
core-ci voted on patch set 9 V -1 06/20/23, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42823
-
Christian Kuhn uploaded patch set 10
V -106/20/23, 09:44 -
core-ci voted on patch set 10 V +1 06/20/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42825
-
Christian Kuhn uploaded patch set 11
V +106/20/23, 10:14 -
core-ci voted on patch set 11 V +1 06/20/23, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42826
-
Stefan Bürk voted on patch set 11 V +1 CR +1 06/20/23, 11:31
-
Benni Mack voted on patch set 11 V +2 CR +2 06/20/23, 12:30
-
Benni Mack merged patch set 12 06/20/23, 12:30