Review main Merged Breaking

79446[!!!][TASK] Cleanup AbstractUserAuthentication and subclasses

Thomas Hohn CR +2 V +2 Normal +59 −74 updated 06/16/23, 18:47

Commit message

The following class methods are now marked as internal in
\TYPO3\CMS\Core\Authentication\AbstractUserAuthentication:
* isSetSessionCookie
* isRefreshTimeBasedCookie
* removeCookie
* isCookieSet
* unpack_uc
* appendCookieToResponse

The following class properties are now marked as internal in
\TYPO3\CMS\Core\Authentication\AbstractUserAuthentication:
* lastLogin_column
* formfield_uname
* formfield_uident
* formfield_status
* loginSessionStarted
* dontSetCookie

The following class properties are now marked as internal in
\TYPO3\CMS\Core\Authentication\FrontendUserAuthentication:
* formfield_permanent
* is_permanent

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 3

Files 7

Review log 67

  1. Thomas Hohn uploaded patch set 1 06/16/23, 16:19

  2. core-ci voted on patch set 1 V +1 06/16/23, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42745

  3. Benni Mack voted on patch set 1 CR +1 06/16/23, 17:02

  4. Oliver Klee voted on patch set 1 V +1 06/16/23, 17:58

  5. Oliver Klee voted on patch set 1 CR +1 06/16/23, 17:59

  6. Benni Mack voted on patch set 1 V +2 CR +2 06/16/23, 18:47

  7. Benni Mack merged patch set 2 06/16/23, 18:47