79449[!!!][TASK] Resolve remaining #[ReturnTypeWillChange] attributes
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- core-ci +1 CI
Issues 3
Files 13
- typo3/sysext/core/Classes/Collection/AbstractRecordCollection.php2+3 −7
- typo3/sysext/core/Classes/Log/LogRecord.php2+1 −4
- typo3/sysext/core/Classes/Messaging/FlashMessageQueue.php2+3 −3
- typo3/sysext/core/Classes/Resource/Collection/AbstractFileCollection.php2+1 −3
- typo3/sysext/core/Classes/Resource/Search/Result/EmptyFileSearchResult.php4+9 −6
- typo3/sysext/core/Classes/Resource/MetaDataAspect.php5+2 −9
- typo3/sysext/core/Classes/Routing/SiteRouteResult.php+0 −3
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-100963-DeprecatedFunctionalityRemoved.rst+24 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyLoadingProxy.php6+3 −9
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyObjectStorage.php2+2 −9
- typo3/sysext/extbase/Classes/Persistence/Generic/QueryResult.php6+6 −13
- typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php+2 −8
- typo3/sysext/filelist/Classes/Dto/ResourceCollection.php4+8 −4
Review log 2129
Show 24 earlier messages
-
Thomas Hohn uploaded patch set 1 06/16/23, 21:04
-
core-ci voted on patch set 1 V -1 06/16/23, 21:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42756
-
Thomas Hohn uploaded patch set 2
V -106/16/23, 21:10 -
core-ci voted on patch set 2 V +1 06/16/23, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42757
-
Thomas Hohn updated the commit message in patch set 3
V +106/16/23, 21:17 -
core-ci voted on patch set 3 V +1 06/16/23, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42758
-
Oliver Klee voted on patch set 3 V +1 06/16/23, 21:52
-
Thomas Hohn updated the commit message in patch set 4
V +106/16/23, 21:54 -
Oliver Klee commented on patch set 4 06/16/23, 21:57
MetaDataAspect.php:93Now that we have the native return type, we can drop the PHPDoc annotation for it. (Ditto for all other similar instances that we're changing in this change.)ResourceCollection.php:158This still is an int. So I propose adding a `@return int` PHPDoc annotation. -
core-ci voted on patch set 4 V +1 06/16/23, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42759
-
Thomas Hohn uploaded patch set 5
V +106/17/23, 05:59 -
core-ci voted on patch set 5 V +1 06/17/23, 06:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42768
-
Oliver Klee commented on patch set 5 06/17/23, 08:08
AbstractFileCollection.php:80ReplyDoneResourceCollection.php:158ReplyDone -
Oliver Klee commented on patch set 5 06/17/23, 08:08
MetaDataAspect.php:93ReplyWe still need to change some other occurrences. -
Thomas Hohn commented on patch set 5 06/17/23, 09:27
MetaDataAspect.php:93ReplyAck -
Oliver Klee commented on patch set 5 06/17/23, 10:12
AbstractRecordCollection.php:101@return T|nullLogRecord.php:306We can drop this PHPDoc annotation.FlashMessageQueue.php:86@return nullMetaDataAspect.php:133We can drop this annotation.EmptyFileSearchResult.php:30@return nullEmptyFileSearchResult.php:36@return nullLazyLoadingProxy.php:192We can drop this annotation.LazyLoadingProxy.php:203@return int (I think)LazyObjectStorage.php:182@return TEntity|nullQueryResult.php:157We can replace the @return and @phpstan-return with this now: ``` @return TValue|null ```QueryResult.php:194We can replace this now with: ``` @return TValue|false ```QueryResult.php:205We now can replace this with: ``` @return int|null ```ResourceCollection.php:153@return ResourceInterface|null -
Thomas Hohn commented on patch set 5 06/17/23, 10:24
AbstractRecordCollection.php:101ReplyDoneLogRecord.php:306ReplyDoneFlashMessageQueue.php:86ReplyDoneMetaDataAspect.php:133ReplyDoneEmptyFileSearchResult.php:30ReplyDoneEmptyFileSearchResult.php:36ReplyDoneLazyLoadingProxy.php:192ReplyDoneLazyLoadingProxy.php:203ReplyAccording to php storm int|string|nullLazyObjectStorage.php:182ReplyDoneQueryResult.php:157ReplyDoneQueryResult.php:194ReplyDoneQueryResult.php:205ReplyDoneResourceCollection.php:153ReplyDone -
Thomas Hohn uploaded patch set 6
V +106/17/23, 10:30 -
core-ci voted on patch set 6 V +1 06/17/23, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42774
-
Oliver Klee commented on patch set 6 06/17/23, 10:39
LazyLoadingProxy.php:203ReplyDone -
Oliver Klee uploaded patch set 7
V +106/17/23, 10:51 -
Oliver Klee voted on patch set 7 V +1 CR +1 06/17/23, 10:51
-
core-ci voted on patch set 7 V +1 06/17/23, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42775
-
Oliver Klee uploaded patch set 8
CR +1V +106/17/23, 15:35 -
Oliver Klee voted on patch set 8 V +1 CR +1 06/17/23, 15:35
-
core-ci voted on patch set 8 V +1 06/17/23, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42782
-
Thomas Hohn commented on patch set 8 06/19/23, 11:11
LazyLoadingProxy.php:203ReplyDone -
Christian Kuhn voted on patch set 8 V +2 CR +2 06/20/23, 10:44
-
Christian Kuhn merged patch set 9 06/20/23, 10:44
AbstractFileCollection.php:80