79451[!!!][TASK] Remove deprecated code in SiteLanguage
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 4
Files 4
- typo3/sysext/core/Classes/Site/Entity/SiteLanguage.php+0 −43
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-100963-DeprecatedFunctionalityRemoved.rst+3 −1
- typo3/sysext/core/Tests/Unit/Site/Entity/SiteLanguageTest.php+0 −2
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+2 −0
Review log 1418
-
Thomas Hohn uploaded patch set 1 06/17/23, 07:18
-
Thomas Hohn uploaded patch set 2 06/17/23, 07:29
-
core-ci voted on patch set 2 V +1 06/17/23, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42772
-
Oliver Klee voted on patch set 2 V +1 06/17/23, 08:05
-
core-ci voted on patch set 1 V -1 06/17/23, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42771
-
Oliver Klee voted on patch set 2 CR +1 06/17/23, 08:24
-
Benni Mack commented on patch set 2 CR -1 06/19/23, 07:23
I think we still need the "hreflang" property, I saw an issue somewhere, will investigate -
Stefan Bürk commented on patch set 2 06/20/23, 01:22
Reply
TYPO3\CMS\Frontend\Http\RequestHandler L294 -
Stefan Bürk commented on patch set 2 06/20/23, 01:23
Reply
Should have looked more into this change :/ -
Benni Mack commented on patch set 2 06/20/23, 12:46
OK. we need to keep the hreflang property. will push a prepatch shortly. -
Benni Mack uploaded patch set 3
CR +1V +107/03/23, 14:33 -
Benni Mack uploaded patch set 4 07/03/23, 14:33
-
Oliver Klee voted on patch set 4 CR +1 07/03/23, 14:34
-
core-ci voted on patch set 4 V +1 07/03/23, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43243
-
core-ci voted on patch set 3 V -1 07/03/23, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43242
-
Oliver Klee voted on patch set 4 V +1 07/03/23, 14:47
-
Benni Mack voted on patch set 4 V +2 CR +2 07/03/23, 15:24
-
Benni Mack merged patch set 5 07/03/23, 15:24