Review main Merged Breaking

79451[!!!][TASK] Remove deprecated code in SiteLanguage

Thomas Hohn CR +2 V +2 Normal +5 −46 updated 07/03/23, 15:24

Commit message

Removed the following public methods:
* \TYPO3\CMS\Core\Site\Entity\SiteLanguage->getTwoLetterIsoCode
* \TYPO3\CMS\Core\Site\Entity\SiteLanguage->getDirection

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 4

Files 4

Review log 1418

  1. Thomas Hohn uploaded patch set 1 06/17/23, 07:18

  2. Thomas Hohn uploaded patch set 2 06/17/23, 07:29

  3. core-ci voted on patch set 2 V +1 06/17/23, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42772

  4. Oliver Klee voted on patch set 2 V +1 06/17/23, 08:05

  5. core-ci voted on patch set 1 V -1 06/17/23, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42771

  6. Oliver Klee voted on patch set 2 CR +1 06/17/23, 08:24

  7. Benni Mack commented on patch set 2 CR -1 06/19/23, 07:23

    I think we still need the "hreflang" property, I saw an issue somewhere, will investigate
  8. Stefan Bürk commented on patch set 2 06/20/23, 01:22

    Reply

    TYPO3\CMS\Frontend\Http\RequestHandler L294
  9. Stefan Bürk commented on patch set 2 06/20/23, 01:23

    Reply

    Should have looked more into this change :/
  10. Benni Mack commented on patch set 2 06/20/23, 12:46

    OK. we need to keep the hreflang property. will push a prepatch shortly.
  11. Benni Mack uploaded patch set 3 CR +1 V +1 07/03/23, 14:33

  12. Benni Mack uploaded patch set 4 07/03/23, 14:33

  13. Oliver Klee voted on patch set 4 CR +1 07/03/23, 14:34

  14. core-ci voted on patch set 4 V +1 07/03/23, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43243

  15. core-ci voted on patch set 3 V -1 07/03/23, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43242

  16. Oliver Klee voted on patch set 4 V +1 07/03/23, 14:47

  17. Benni Mack voted on patch set 4 V +2 CR +2 07/03/23, 15:24

  18. Benni Mack merged patch set 5 07/03/23, 15:24