Review main Merged

79452[FEATURE] Show if redirects were checked in report

Sybille Peters CR +2 V +2 Hard +265 −10 updated 07/06/23, 09:51

Commit message

In the status report there is an additional entry to show if redirect
conflicts have been found.

However, there was no indication if / when the last check was run.
If there were no conflicts a status of "ok" was reported which can
be quite misleading if a redirects check was not performed lately.

We now write a timestamp in the registry when checking redirects,
along with the result of "checkintegrity". These are 2 separate
registry entries.

The timestamp is queried in the report generation and an additional
"info" status is displayed if the timestamp indicates that the
check was run more than 24h ago or never run at all.

The new behaviour is configurable in the extension configuration.
If extensions provide other means to check redirects, they can
set the timestamp in the registry (see CheckIntegrityCommand)
or the behaviour can be deactivated.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1221

  1. Sybille Peters uploaded patch set 1 06/17/23, 11:58

  2. Sybille Peters updated the commit message in patch set 2 06/17/23, 11:59

  3. Sybille Peters uploaded patch set 3 06/17/23, 12:03

  4. Sybille Peters uploaded patch set 4 06/17/23, 12:04

  5. core-ci voted on patch set 3 V +1 06/17/23, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42778

  6. core-ci voted on patch set 4 V +1 06/17/23, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42779

  7. core-ci voted on patch set 1 V +1 06/17/23, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42776

  8. core-ci voted on patch set 2 V -1 06/17/23, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42777

  9. Sybille Peters uploaded patch set 5 V +1 06/17/23, 12:44

  10. core-ci voted on patch set 5 V +1 06/17/23, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42780

  11. Sybille Peters uploaded patch set 6 V +1 06/19/23, 05:32

  12. core-ci voted on patch set 6 V -1 06/19/23, 05:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42798

  13. Sybille Peters uploaded patch set 7 V -1 06/19/23, 05:40

  14. Sybille Peters uploaded patch set 8 06/19/23, 05:44

  15. core-ci voted on patch set 7 V -1 06/19/23, 05:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42799

  16. core-ci voted on patch set 8 V +1 06/19/23, 05:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42800

  17. Nikita Hovratov uploaded patch set 9 V +1 06/23/23, 14:04

  18. Nikita Hovratov voted on patch set 9 V +1 CR +1 06/23/23, 14:06

  19. core-ci voted on patch set 9 V +1 06/23/23, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42931

  20. Stefan Bürk voted on patch set 9 V +2 CR +2 07/06/23, 09:51

  21. Stefan Bürk merged patch set 10 07/06/23, 09:51