Review main Abandoned

79456[BUGFIX] Improve visibility of multicontent in backend layout

Jasmina Ließmann CR 0 V 0 Easy +2 −2 updated 07/06/23, 08:54

Commit message

With #98308 the table attribute 'width' was removed from page layout
grid without adding a corresponding CSS property to replace it.
We are now adding CSS property 'table-responsive' on 't3-grid-container-inner'
to fix display issues in language comparison mode and in backend layouts.

With #97306 the appearance of the content area in page module has
been updated. As a result, depending on the current viewport, not
all columns were fully visible and editable when multiple columns
were defined in a row in the backend layout.
With this patch, the columns are now made accessible to the user
again.
The view should be further optimized.

Review

  • Code review CR 0
  • Verified V 0

Issues 5

Files 2

Review log 913

  1. Jasmina Ließmann uploaded patch set 1 06/18/23, 20:59

  2. core-ci voted on patch set 1 V +1 06/18/23, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42792

  3. Jasmina Ließmann updated the commit message in patch set 2 V +1 06/26/23, 14:25

  4. core-ci voted on patch set 2 V +1 06/26/23, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42985

  5. Andreas Nedbal commented on patch set 2 06/27/23, 08:46

    _page.scss:44

    This exact fix is also present in https://review.typo3.org/c/Packages/TYPO3.CMS/+/79455, shouldn't this be removed here?
  6. Jasmina Ließmann commented on patch set 2 06/29/23, 08:22

    _page.scss:44 Reply

    It's needed here as well. As long as the other patch isn't merged it's present in both patches.
  7. Jasmina Ließmann updated the commit message in patch set 3 V +1 07/02/23, 18:24

  8. core-ci voted on patch set 3 V +1 07/02/23, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43194

  9. Andreas Nedbal voted on patch set 3 V +1 CR +1 07/03/23, 07:34

  10. Annett Jähnichen uploaded patch set 4 CR +1 V +1 07/03/23, 19:19

  11. core-ci voted on patch set 4 V +1 07/03/23, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43284

  12. Annett Jähnichen commented on patch set 4 CR -1 07/05/23, 11:53

    We are on it
  13. Jasmina Ließmann abandoned the change 07/06/23, 08:54