Review main Merged Breaking

79463[!!!][TASK] Clean up extbase UriBuilder

Christian Kuhn CR +2 V +2 Hard +349 −492 updated 06/22/23, 09:20

Commit message

Extbase UriBuilder now has a hard dependency to
request, the class is streamlined a bit along
the way. The current cObj must be provided as
extbase request attribute to generate frontend
URI.

The UriBuilder test is simplified towards less
state, some consuming tests are adapted to deal
with the request and currentContentObject
requirement.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 3

Files 11

Review log 812

  1. Christian Kuhn uploaded patch set 1 06/20/23, 15:21

  2. core-ci voted on patch set 1 V -1 06/20/23, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42833

  3. Christian Kuhn uploaded patch set 2 V -1 06/21/23, 08:35

  4. core-ci voted on patch set 2 V -1 06/21/23, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42867

  5. Christian Kuhn uploaded patch set 3 V -1 06/21/23, 09:02

  6. core-ci voted on patch set 3 V +1 06/21/23, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42868

  7. Christian Kuhn uploaded patch set 4 V +1 06/21/23, 09:14

  8. Benni Mack voted on patch set 4 CR +1 06/21/23, 09:19

  9. core-ci voted on patch set 4 V +1 06/21/23, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42869

  10. Nikita Hovratov voted on patch set 4 V +1 CR +1 06/22/23, 09:13

  11. Benni Mack voted on patch set 4 V +2 CR +2 06/22/23, 09:20

  12. Benni Mack merged patch set 5 06/22/23, 09:20