Review main Merged

79467[TASK] Raise `phpstan/phpstan` and friends

Stefan Bürk CR +2 V +2 Easy +14 −19 updated 06/21/23, 05:15

Commit message

This change raises phpstan and related
package to the latest version. Baseline
is recreated to remove no longer matched
error ignore pattern.

Used command(s):

> composer require --dev \
    "phpstan/phpstan":"^1.10.20" \
    "phpstan/phpstan-phpunit":"^1.3.13"

> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Thomas Hohn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Stefan Bürk uploaded patch set 1 06/21/23, 02:16

  2. Stefan Bürk uploaded patch set 2 06/21/23, 02:21

  3. core-ci voted on patch set 2 V +1 06/21/23, 02:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42853

  4. core-ci voted on patch set 1 V -1 06/21/23, 02:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42852

  5. Thomas Hohn voted on patch set 2 CR +1 06/21/23, 05:03

  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 06/21/23, 05:15

  7. Anja Leichsenring merged patch set 3 06/21/23, 05:15