Review main Merged Breaking

79471[!!!][TASK] Added setModuleData method to ShortInfoProviderInterface

Thomas Hohn CR +2 V +2 Easy +3 −14 updated 06/22/23, 09:58

Commit message

Classes must implement the method setModuleData, when implementing
the \TYPO3\CMS\Adminpanel\ModuleApi\ShortInfoProviderInterface.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 67

  1. Thomas Hohn uploaded patch set 1 06/21/23, 10:07

  2. core-ci voted on patch set 1 V +1 06/21/23, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42873

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 06/22/23, 08:55

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 06/22/23, 09:23

  5. Nikita Hovratov voted on patch set 1 V +2 CR +2 06/22/23, 09:23

  6. Nikita Hovratov merged patch set 2 06/22/23, 09:23

  7. Simon Schaufelberger commented on patch set 2 06/22/23, 09:58

    no past tense in the commit message. just fyi