Review main Merged Breaking

79472[!!!][TASK] Remove pages.doktype 255 / recycler

Benni Mack CR +2 V +2 Hard +241 −140 updated 07/04/23, 08:03

Commit message

Historically, TYPO3 Core has had a custom page doktype
"recycler" which was used as a "manual trash bin" so editors
could park / move records to that location instead of deleting
them.

However, the concept of the actual "recycler" (where the GUI is
in the system extension recycler) is to actually
use the "soft-delete" feature and restore / undelete records based
on the GUI. There is a huge advantage, as the records are kept
on the actual Page ID instead of a custom recycler.

In order to avoid confusion, the manual logic of pages.doktype=255
as a recycler to have editors move content manually in there, is removed.

The TCA is adapted, and the constant PageRepository::DOKTYPE_RECYCLER
is removed as well.

People who want to use a recycler, can use the recycler system
extension.

An upgrade wizard moves pages of type "doktype 255" to a regular
Backend User Section with a prefix "[RECYCLER] " in the page title.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 29

Show 9 more files

Review log 1116

  1. Benni Mack uploaded patch set 1 06/21/23, 10:19

  2. core-ci voted on patch set 1 V +1 06/21/23, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42874

  3. Benni Mack updated the commit message in patch set 2 V +1 06/23/23, 07:04

  4. core-ci voted on patch set 2 V +1 06/23/23, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42926

  5. Benni Mack uploaded patch set 3 V +1 07/03/23, 15:17

  6. Benni Mack uploaded patch set 4 07/03/23, 15:22

  7. core-ci voted on patch set 3 V +1 07/03/23, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43247

  8. core-ci voted on patch set 4 V +1 07/03/23, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43249

  9. Frank Nägler voted on patch set 4 V +1 CR +1 07/03/23, 18:58

  10. Jochen Roth voted on patch set 4 V +1 CR +1 07/03/23, 19:15

  11. Benni Mack uploaded patch set 5 CR +1 V +1 07/03/23, 20:02

  12. Benni Mack rebased onto patch set 6 07/04/23, 07:17

  13. core-ci voted on patch set 6 V +1 07/04/23, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43336

  14. Andreas Kienast voted on patch set 6 V +1 CR +1 07/04/23, 07:44

  15. Stefan Bürk voted on patch set 6 V +2 CR +2 07/04/23, 08:03

  16. Stefan Bürk merged patch set 7 07/04/23, 08:03