Review main Merged

79473[TASK] Trigger deprecation warnings in Repository for magic methods

Thomas Hohn CR +2 V +2 Easy +12 −15 updated 06/22/23, 09:24

Commit message

Trigger deprecations for the following magic methods
in TYPO3\CMS\Extbase\Persistence\Repository:
* findBy[Property]()
* findOneBy[Property]()
* countBy[Property]()

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 79

  1. Thomas Hohn uploaded patch set 1 06/21/23, 10:25

  2. Mathias Brodala commented on patch set 1 06/21/23, 10:30

    From what I can see this is not a breaking change since everything works like before.
  3. core-ci voted on patch set 1 V +1 06/21/23, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42875

  4. Thomas Hohn updated the commit message in patch set 2 V +1 06/21/23, 10:33

  5. Thomas Hohn commented on patch set 2 06/21/23, 10:33

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 06/21/23, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42876

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 06/22/23, 08:54

  8. Nikita Hovratov voted on patch set 2 V +2 CR +2 06/22/23, 09:24

  9. Nikita Hovratov merged patch set 3 06/22/23, 09:24