Review main Merged

79475[TASK] Remove trigger deprecation in AbstractFormEngineAjaxController

Thomas Hohn CR +2 V +2 Easy +1 −4 updated 06/22/23, 08:51

Commit message

Removed the trigger of a deprecation warning and removed 3rd argument
in class TYPO3\CMS\Backend\Controller\AbstractFormEngineAjaxController
for method:
* addJavaScriptModulesToJavaScriptItems

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 4

Files 1

Review log 57

  1. Thomas Hohn uploaded patch set 1 06/21/23, 11:43

  2. core-ci voted on patch set 1 V -1 06/21/23, 11:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42879

  3. Thomas Hohn uploaded patch set 2 V -1 06/21/23, 12:15

  4. core-ci voted on patch set 2 V +1 06/21/23, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42880

  5. Oliver Klee voted on patch set 2 V +1 CR +1 06/21/23, 13:30

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 06/22/23, 08:51

  7. Christian Kuhn merged patch set 3 06/22/23, 08:51