79476[!!!][TASK] Convert Action to backed enum
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Alexander Schnitzler +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Alexander Schnitzler +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-101129-ConvertActionToNativeEnum.rstnew+54 −0
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTaskAdditionalFieldProvider.php+15 −15
- typo3/sysext/recycler/Classes/Task/CleanerFieldProvider.php+2 −2
- typo3/sysext/reports/Classes/Task/SystemStatusUpdateTaskNotificationEmailField.php+2 −2
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php2+12 −9
- typo3/sysext/scheduler/Classes/Task/CachingFrameworkGarbageCollectionAdditionalFieldProvider.php+3 −3
- typo3/sysext/scheduler/Classes/Task/IpAnonymizationAdditionalFieldProvider.php+3 −3
- typo3/sysext/scheduler/Classes/Task/OptimizeDatabaseTableAdditionalFieldProvider.php+3 −3
- typo3/sysext/scheduler/Classes/Task/RecyclerGarbageCollectionAdditionalFieldProvider.php+2 −2
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionAdditionalFieldProvider.php+6 −6
- typo3/sysext/scheduler/Classes/SchedulerManagementAction.phprenamed+6 −9
Review log 2534
Show 69 earlier messages
-
Thomas Hohn uploaded patch set 1 06/21/23, 13:55
-
core-ci voted on patch set 1 V -1 06/21/23, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42883
-
Thomas Hohn uploaded patch set 2
V -106/21/23, 14:47 -
core-ci voted on patch set 2 V +1 06/21/23, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42884
-
Nikita Hovratov commented on patch set 2 CR -1 06/23/23, 12:30
Action.php:26I think we don't need a backed enum here, since the strings `add`, `edit` and `list` do not appear anywhere, but are simply set accordingly for the action context.Action.php:30This method is completely unnecessary. Just compare two enums with `$currentSchedulerModuleAction === Action::ADD` -
Thomas Hohn commented on patch set 2 06/23/23, 21:23
Action.php:26ReplyI'm not sure I understand this argument. The strings are used in AdditionalProviders and I think it would be cleaner to referer to the through the Action enum. -
Thomas Hohn uploaded patch set 3
CR -1V +106/23/23, 21:52 -
Thomas Hohn uploaded patch set 4 06/23/23, 21:53
-
core-ci voted on patch set 3 V +1 06/23/23, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42934
-
core-ci voted on patch set 4 V +1 06/23/23, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42935
-
Thomas Hohn commented on patch set 4 06/24/23, 05:49
SchedulerModuleController.php:456ReplyAckAction.php:26ReplyAckAction.php:30ReplyAck -
Thomas Hohn uploaded patch set 5
V +107/24/23, 08:27 -
core-ci voted on patch set 5 V +1 07/24/23, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44461
-
Stefan Bürk commented on patch set 5 07/24/23, 08:37
Action.php:24Not sure .. I think, we can at least remove the `Enumeration` part from the namepsace and move this .. or change to "Type" or something like that. What do you think ? -
Thomas Hohn commented on patch set 5 07/24/23, 08:45
Action.php:24ReplyI have another PR that suggests not to put it in the Type namespace. I would suggest to put it in TYPO3\CMS\Scheduler instead - what do you think about that? -
Stefan Bürk commented on patch set 5 07/24/23, 09:01
Action.php:24ReplyAck. -
Thomas Hohn uploaded patch set 6
V +107/24/23, 09:22 -
Thomas Hohn commented on patch set 6 07/24/23, 09:24
Action.php:24ReplyDone -
core-ci voted on patch set 6 V +1 07/24/23, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44465
-
Benni Mack commented on patch set 6 07/24/23, 11:08
Can we rename this Enum to "SchedulerManagementAction" -
Thomas Hohn uploaded patch set 7
V +107/24/23, 13:37 -
Thomas Hohn commented on patch set 7 07/24/23, 13:38
Reply
Done -
core-ci voted on patch set 7 V -1 07/24/23, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44470
-
Thomas Hohn uploaded patch set 8
V -107/24/23, 13:49 -
core-ci voted on patch set 8 V +1 07/24/23, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44471
-
Oliver Klee voted on patch set 8 V +1 07/24/23, 14:10
-
Oliver Klee voted on patch set 8 CR +1 07/24/23, 14:11
-
Benni Mack commented on patch set 9
CR +1V +107/24/23, 15:09Published edit on patch set 8. -
Benni Mack voted on patch set 9 V +1 CR +1 07/24/23, 15:09
-
core-ci voted on patch set 9 V +1 07/24/23, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44479
-
Oliver Klee voted on patch set 9 CR +1 07/24/23, 15:32
-
Alexander Schnitzler voted on patch set 9 V +1 CR +1 07/24/23, 17:09
-
Stefan Bürk voted on patch set 9 V +2 CR +2 07/24/23, 19:28
-
Stefan Bürk merged patch set 10 07/24/23, 19:28
SchedulerModuleController.php:456