Review main Merged Breaking

79476[!!!][TASK] Convert Action to backed enum

Thomas Hohn CR +2 V +2 Normal +108 −54 updated 07/24/23, 19:28

Commit message

This change converts class Action to a native backed enum.
In addition it's moved to namespace \TYPO3\CMS\Scheduler\ and
renamed to SchedulerManagementAction.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Alexander Schnitzler +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 2534

Show 69 earlier messages
  1. Thomas Hohn uploaded patch set 1 06/21/23, 13:55

  2. core-ci voted on patch set 1 V -1 06/21/23, 14:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42883

  3. Thomas Hohn uploaded patch set 2 V -1 06/21/23, 14:47

  4. core-ci voted on patch set 2 V +1 06/21/23, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42884

  5. Nikita Hovratov commented on patch set 2 CR -1 06/23/23, 12:30

    SchedulerModuleController.php:456

    Just do `$this->currentAction = Action::EDIT`

    Action.php:26

    I think we don't need a backed enum here, since the strings `add`, `edit` and `list` do not appear anywhere, but are simply set accordingly for the action context.

    Action.php:30

    This method is completely unnecessary. Just compare two enums with `$currentSchedulerModuleAction === Action::ADD`
  6. Thomas Hohn commented on patch set 2 06/23/23, 21:23

    Action.php:26 Reply

    I'm not sure I understand this argument. The strings are used in AdditionalProviders and I think it would be cleaner to referer to the through the Action enum.
  7. Thomas Hohn uploaded patch set 3 CR -1 V +1 06/23/23, 21:52

  8. Thomas Hohn uploaded patch set 4 06/23/23, 21:53

  9. core-ci voted on patch set 3 V +1 06/23/23, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42934

  1. core-ci voted on patch set 4 V +1 06/23/23, 22:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42935

  2. Thomas Hohn commented on patch set 4 06/24/23, 05:49

    SchedulerModuleController.php:456 Reply

    Ack

    Action.php:26 Reply

    Ack

    Action.php:30 Reply

    Ack
  3. Thomas Hohn uploaded patch set 5 V +1 07/24/23, 08:27

  4. core-ci voted on patch set 5 V +1 07/24/23, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44461

  5. Stefan Bürk commented on patch set 5 07/24/23, 08:37

    Action.php:24

    Not sure .. I think, we can at least remove the `Enumeration` part from the namepsace and move this .. or change to "Type" or something like that. What do you think ?
  6. Thomas Hohn commented on patch set 5 07/24/23, 08:45

    Action.php:24 Reply

    I have another PR that suggests not to put it in the Type namespace. I would suggest to put it in TYPO3\CMS\Scheduler instead - what do you think about that?
  7. Stefan Bürk commented on patch set 5 07/24/23, 09:01

    Action.php:24 Reply

    Ack.
  8. Thomas Hohn uploaded patch set 6 V +1 07/24/23, 09:22

  9. Thomas Hohn commented on patch set 6 07/24/23, 09:24

    Action.php:24 Reply

    Done
  10. core-ci voted on patch set 6 V +1 07/24/23, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44465

  11. Benni Mack commented on patch set 6 07/24/23, 11:08

    Can we rename this Enum to "SchedulerManagementAction"
  12. Thomas Hohn uploaded patch set 7 V +1 07/24/23, 13:37

  13. Thomas Hohn commented on patch set 7 07/24/23, 13:38

    Reply

    Done
  14. core-ci voted on patch set 7 V -1 07/24/23, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44470

  15. Thomas Hohn uploaded patch set 8 V -1 07/24/23, 13:49

  16. core-ci voted on patch set 8 V +1 07/24/23, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44471

  17. Oliver Klee voted on patch set 8 V +1 07/24/23, 14:10

  18. Oliver Klee voted on patch set 8 CR +1 07/24/23, 14:11

  19. Benni Mack commented on patch set 9 CR +1 V +1 07/24/23, 15:09

    Published edit on patch set 8.
  20. Benni Mack voted on patch set 9 V +1 CR +1 07/24/23, 15:09

  21. core-ci voted on patch set 9 V +1 07/24/23, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44479

  22. Oliver Klee voted on patch set 9 CR +1 07/24/23, 15:32

  23. Alexander Schnitzler voted on patch set 9 V +1 CR +1 07/24/23, 17:09

  24. Stefan Bürk voted on patch set 9 V +2 CR +2 07/24/23, 19:28

  25. Stefan Bürk merged patch set 10 07/24/23, 19:28