Review main Merged Breaking

79478[!!!][TASK] Enforce strict typing in LinktypeInterface

Thomas Hohn CR +2 V +2 Normal +88 −55 updated 06/23/23, 08:53

Commit message

Enforce that all methods are strictly typed in the interface:
\TYPO3\CMS\Linkvalidator\Linktype\LinktypeInterface

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1925

  1. Thomas Hohn uploaded patch set 1 06/22/23, 06:15

  2. core-ci voted on patch set 1 V -1 06/22/23, 06:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42895

  3. Oliver Klee commented on patch set 1 06/22/23, 06:34

    This change fixes some PHPStan warnings. So we'll need to regenerate the PHPStan baseline.

    LinktypeRegistryTest.php:20

    This line looks like it shouldn't be part of this change.
  4. Oliver Klee commented on patch set 1 06/22/23, 06:35

    I propose we also mark the affected files as strict in order to enforce the strict types we're adding.
  5. Thomas Hohn commented on patch set 1 06/22/23, 06:47

    Reply

    Ack

    Reply

    Yes
  6. Thomas Hohn uploaded patch set 2 V -1 06/22/23, 07:00

  7. Thomas Hohn commented on patch set 2 06/22/23, 07:05

    LinktypeRegistryTest.php:20 Reply

    Done
  8. core-ci voted on patch set 2 V -1 06/22/23, 07:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42897

  9. Thomas Hohn uploaded patch set 3 V -1 06/22/23, 07:36

  10. core-ci voted on patch set 3 V -1 06/22/23, 07:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42898

  11. Thomas Hohn uploaded patch set 4 V -1 06/22/23, 08:08

  12. core-ci voted on patch set 4 V -1 06/22/23, 08:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42899

  13. Thomas Hohn commented on patch set 4 06/22/23, 08:26

    phpstan-baseline.neon:1084

    Hi Oliver - I'm a bit unsure why the base-line generation added this one? Seems to break the tests
  14. Oliver Klee commented on patch set 4 06/22/23, 08:33

    phpstan-baseline.neon:1084 Reply

    My first guess would be that you might an older version of PHPStan. Try updating it: ``` ./Build/Scripts/runTests.sh -s composerInstall ```
  15. Oliver Klee commented on patch set 4 06/22/23, 08:39

    phpstan-baseline.neon:1084 Reply

    Argh. Not enough coffee yet: might -> might have
  16. Thomas Hohn uploaded patch set 5 V -1 06/22/23, 09:07

  17. Oliver Klee commented on patch set 5 V +1 CR +1 06/22/23, 09:09

    phpstan-baseline.neon:1084 Reply

    Done
  18. Oliver Klee commented on patch set 5 CR 0 06/22/23, 09:11

    AbstractLinktype.php:32

    Oh, should we make this a native array as well?
  19. core-ci voted on patch set 5 V +1 06/22/23, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42902

  20. Thomas Hohn uploaded patch set 6 V +1 06/22/23, 09:17

  21. Thomas Hohn commented on patch set 6 06/22/23, 09:18

    AbstractLinktype.php:32 Reply

    Ack
  22. core-ci voted on patch set 6 V +1 06/22/23, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42904

  23. Oliver Klee voted on patch set 6 V +1 CR +1 06/22/23, 09:47

  24. Benni Mack voted on patch set 6 V +2 CR +2 06/23/23, 08:53

  25. Benni Mack merged patch set 7 06/23/23, 08:53