79478[!!!][TASK] Enforce strict typing in LinktypeInterface
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 11
- Build/phpstan/phpstan-baseline.neon4+0 −10
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-101143-StrictTypingLinktypeInterface.rstnew+39 −0
- typo3/sysext/linkvalidator/Classes/Linktype/AbstractLinktype.php2+6 −5
- typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php+7 −10
- typo3/sysext/linkvalidator/Classes/Linktype/FileLinktype.php+8 −6
- typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php+6 −4
- typo3/sysext/linkvalidator/Classes/Linktype/LinktypeInterface.php+9 −7
- typo3/sysext/linkvalidator/Classes/Repository/BrokenLinkRepository.php+3 −4
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Examples/ExampleLinkType.rst.txt+2 −2
- typo3/sysext/linkvalidator/Tests/Unit/Linktype/ExternalLinktypeTest.php+2 −2
- typo3/sysext/linkvalidator/Tests/Unit/Linktype/LinktypeRegistryTest.php2+6 −5
Review log 1925
-
Thomas Hohn uploaded patch set 1 06/22/23, 06:15
-
core-ci voted on patch set 1 V -1 06/22/23, 06:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42895
-
Oliver Klee commented on patch set 1 06/22/23, 06:34
This change fixes some PHPStan warnings. So we'll need to regenerate the PHPStan baseline.LinktypeRegistryTest.php:20This line looks like it shouldn't be part of this change. -
Oliver Klee commented on patch set 1 06/22/23, 06:35
I propose we also mark the affected files as strict in order to enforce the strict types we're adding. -
Thomas Hohn uploaded patch set 2
V -106/22/23, 07:00 -
Thomas Hohn commented on patch set 2 06/22/23, 07:05
LinktypeRegistryTest.php:20ReplyDone -
core-ci voted on patch set 2 V -1 06/22/23, 07:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42897
-
Thomas Hohn uploaded patch set 3
V -106/22/23, 07:36 -
core-ci voted on patch set 3 V -1 06/22/23, 07:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42898
-
Thomas Hohn uploaded patch set 4
V -106/22/23, 08:08 -
core-ci voted on patch set 4 V -1 06/22/23, 08:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42899
-
Thomas Hohn commented on patch set 4 06/22/23, 08:26
phpstan-baseline.neon:1084Hi Oliver - I'm a bit unsure why the base-line generation added this one? Seems to break the tests -
Oliver Klee commented on patch set 4 06/22/23, 08:33
phpstan-baseline.neon:1084ReplyMy first guess would be that you might an older version of PHPStan. Try updating it: ``` ./Build/Scripts/runTests.sh -s composerInstall ``` -
Oliver Klee commented on patch set 4 06/22/23, 08:39
phpstan-baseline.neon:1084ReplyArgh. Not enough coffee yet: might -> might have -
Thomas Hohn uploaded patch set 5
V -106/22/23, 09:07 -
Oliver Klee commented on patch set 5 V +1 CR +1 06/22/23, 09:09
phpstan-baseline.neon:1084ReplyDone -
Oliver Klee commented on patch set 5 CR 0 06/22/23, 09:11
AbstractLinktype.php:32Oh, should we make this a native array as well? -
core-ci voted on patch set 5 V +1 06/22/23, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42902
-
Thomas Hohn uploaded patch set 6
V +106/22/23, 09:17 -
Thomas Hohn commented on patch set 6 06/22/23, 09:18
AbstractLinktype.php:32ReplyAck -
core-ci voted on patch set 6 V +1 06/22/23, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42904
-
Oliver Klee voted on patch set 6 V +1 CR +1 06/22/23, 09:47
-
Benni Mack voted on patch set 6 V +2 CR +2 06/23/23, 08:53
-
Benni Mack merged patch set 7 06/23/23, 08:53