79481[BUGFIX] Declare FormEngine NodeInterface classes stateful
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 911
-
Christian Kuhn uploaded patch set 1 06/22/23, 10:52
-
Mathias Brodala commented on patch set 1 06/22/23, 10:55
-
core-ci voted on patch set 1 V +1 06/22/23, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42908
-
Benni Mack commented on patch set 1 V +1 CR +1 06/22/23, 11:38
Services.php:26ReplyI wouldn't start using named arguments here as people tend to look at core code for reference. Since we only use named arguments currently in tests, and try to avoid it unless we have clearly defined our Backwards-compat promise regarding named arguments, I would prefer to not introduce named arguments in production code of TYPO3 Core with this tiny change. I do agree with your reasoning though! Maybe a comment would be a good idea for the time being? -
Christian Kuhn commented on patch set 1 06/22/23, 11:49
Services.php:26Replyi'll add a comment. -
Christian Kuhn uploaded patch set 2
CR +1V +106/22/23, 11:53 -
Benni Mack voted on patch set 2 V +1 CR +1 06/22/23, 11:56
-
core-ci voted on patch set 2 V +1 06/22/23, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42909
-
Nikita Hovratov voted on patch set 2 V +1 CR +1 06/22/23, 12:23
-
Christian Kuhn voted on patch set 2 V +2 CR +2 06/22/23, 12:28
-
Christian Kuhn merged patch set 3 06/22/23, 12:28
Services.php:26