Review main Merged Breaking

79483[!!!][TASK] Mark PageTsBackendLayoutDataProvider as final

Thomas Hohn CR +2 V +2 Normal +43 −18 updated 06/26/23, 13:03

Commit message

The class following class is marked as internal:
* \TYPO3\CMS\Backend\View\BackendLayout\PageTsBackendLayoutDataProvider

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1318

  1. Thomas Hohn uploaded patch set 1 06/22/23, 13:41

  2. core-ci voted on patch set 1 V -1 06/22/23, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42911

  3. Thomas Hohn uploaded patch set 2 V -1 06/22/23, 13:51

  4. core-ci voted on patch set 2 V +1 06/22/23, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42912

  5. Oliver Klee commented on patch set 2 06/22/23, 14:34

    PageTsBackendLayoutDataProvider.php:153

    I propose we remove the PHPDoc annotations (that have no comments) for which we now have native type declarations (multiple occurrences).
  6. Thomas Hohn commented on patch set 2 06/23/23, 05:30

    PageTsBackendLayoutDataProvider.php:153 Reply

    Ack
  7. Oliver Klee commented on patch set 2 06/23/23, 07:06

    PageTsBackendLayoutDataProvider.php:153 Reply

    This is not done yet. (For review comments that are to be done, I recommend commenting "Done." only when they are done so that they do not get lost. "Ack" means "I've read/acknowledged this, but there is nothing to do about it right now."
  8. Thomas Hohn uploaded patch set 3 V +1 06/24/23, 06:57

  9. Thomas Hohn commented on patch set 3 06/24/23, 06:58

    PageTsBackendLayoutDataProvider.php:153 Reply

    Ack
  10. Thomas Hohn uploaded patch set 4 06/24/23, 06:59

  11. core-ci voted on patch set 4 V +1 06/24/23, 07:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42942

  12. core-ci voted on patch set 3 V +1 06/24/23, 07:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42941

  13. Oliver Klee voted on patch set 4 V +1 CR +1 06/24/23, 08:36

  14. Benni Mack commented on patch set 5 CR +1 V +1 06/26/23, 08:31

    Published edit on patch set 4.
  15. core-ci voted on patch set 5 V +1 06/26/23, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42978

  16. Benni Mack voted on patch set 5 V +1 CR +1 06/26/23, 10:50

  17. Stefan Bürk voted on patch set 5 V +2 CR +2 06/26/23, 13:03

  18. Stefan Bürk merged patch set 6 06/26/23, 13:03