Review main Merged

79486[TASK] Simplify FormEngine PaletteAndSingleContainer

Christian Kuhn CR +2 V +2 Normal +53 −82 updated 06/22/23, 19:28

Commit message

As a pre-patch to resolve #97330, we simplify the
code flow in PaletteAndSingleContainer by avoiding
the fieldSetWrap() method and inlining it in a
simplified form to the calling methods. This makes
the purpose more clear and allows detail changes
to the generated HTML depending on generated palettes.

This is just a code-flow cleanup that does not
influence generated HTML.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 78

  1. Christian Kuhn uploaded patch set 1 06/22/23, 18:40

  2. core-ci voted on patch set 1 V +1 06/22/23, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42917

  3. Benni Mack voted on patch set 1 V +1 CR +1 06/22/23, 19:13

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 06/22/23, 19:15

  5. Nikita Hovratov voted on patch set 1 V +1 CR +1 06/22/23, 19:17

  6. Stefan Bürk voted on patch set 1 V +1 CR +1 06/22/23, 19:26

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 06/22/23, 19:28

  8. Christian Kuhn merged patch set 2 06/22/23, 19:28