Review main Merged

79489[BUGFIX] Prevent PHP warning using unsetLimit

Stefan Froemken CR +2 V +2 Easy +29 −3 updated 06/25/23, 21:01

Commit message

The extbase implemantation "Query" of the
QueryInterface contains a method "unsetLimit".
Calling this method really PHP:unset()'s the
$limit property from Query object. That will
produce various PHP warnings where getLimit()
is called.
As $limit is initialized with null while
instanciation, calling unsetLimit() will now
reset $limit to null again instead of removing
the complete property.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Stefan Froemken uploaded patch set 1 06/24/23, 11:10

  2. core-ci voted on patch set 1 V -1 06/24/23, 11:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42944

  3. Stefan Froemken uploaded patch set 2 V -1 06/24/23, 13:19

  4. core-ci voted on patch set 2 V -1 06/24/23, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42945

  5. Stefan Froemken uploaded patch set 3 V -1 06/24/23, 13:38

  6. core-ci voted on patch set 3 V +1 06/24/23, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42946

  7. Oliver Klee commented on patch set 3 V +1 CR +1 06/24/23, 18:24

    QueryTest.php:120

    Beautiful tests!
  8. Stefan Froemken commented on patch set 3 06/24/23, 21:03

    QueryTest.php:120 Reply

    I had a good teacher ;-)
  9. Oliver Klee commented on patch set 3 06/25/23, 12:43

    QueryTest.php:120 Reply

    ;-) <3
  10. Benni Mack voted on patch set 3 V +2 CR +2 06/25/23, 21:01

  11. Benni Mack merged patch set 4 06/25/23, 21:01