Review main Merged

79496[BUGFIX] Have site settings in pageTsConfig

Christian Kuhn CR +2 V +2 Easy +5 −7 updated 06/27/23, 08:52

Commit message

A broken cache handling related to site settings
in PageTsConfigFactory effectively leads to
broken access to site settings related
"constants". The patch fixes the cache handling.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1013

  1. Christian Kuhn uploaded patch set 1 06/26/23, 21:07

  2. core-ci voted on patch set 1 V +1 06/26/23, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42997

  3. Christian Kuhn uploaded patch set 2 V +1 06/26/23, 21:25

  4. core-ci voted on patch set 2 V +1 06/26/23, 21:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42998

  5. Jasmina Ließmann voted on patch set 2 V +1 CR +1 06/27/23, 08:15

  6. Markus Klein commented on patch set 2 06/27/23, 08:24

    PageTsConfigFactory.php:87

    I'd simplify to: if (isset($siteSettingsCacheArray['flatConstants']))
  7. Christian Kuhn uploaded patch set 3 CR +1 V +1 06/27/23, 08:26

  8. Christian Kuhn commented on patch set 2 06/27/23, 08:26

    PageTsConfigFactory.php:87 Reply

    Done
  9. Jasmina Ließmann voted on patch set 3 V +1 CR +1 06/27/23, 08:27

  10. core-ci voted on patch set 3 V +1 06/27/23, 08:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43011

  11. Benni Mack voted on patch set 3 V +1 CR +1 06/27/23, 08:37

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 06/27/23, 08:52

  13. Christian Kuhn merged patch set 4 06/27/23, 08:52