79514[BUGFIX] Avoid symfony/property-access in getGettablePropertyNames()
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1011
-
Alexander Schnitzler uploaded patch set 1 06/27/23, 07:21
-
core-ci voted on patch set 1 V +1 06/27/23, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43006
-
Alexander Schnitzler marked it ready for review 06/27/23, 07:38
-
Alexander Schnitzler wrote 06/27/23, 07:38
Topic set to extbase -
Benni Mack commented on patch set 1 06/27/23, 08:39
should we also change this in getSettablePropertyNames ? -
Alexander Schnitzler commented on patch set 1 06/27/23, 10:00
Reply
I'm not too sure about the performance impact there (yet). But yes, IMHO we should avoid symfony/property-access altogether because we cannot share our reflection caches with them. But I'd like to keep commits simple and short and do one after the other so we can better decide what to backport as bugfix and what not. -
Markus Klein commented on patch set 1 CR +1 06/28/23, 11:46
I'm testing this also on older v10 now -
Markus Klein commented on patch set 1 V +1 06/28/23, 12:10
In my testcase the speed-improvement was slightly noticeable. And nothing seems to be broken. -
Oliver Klee voted on patch set 1 V +1 CR +1 06/28/23, 20:29
-
Benni Mack voted on patch set 1 V +2 CR +2 07/04/23, 09:49
-
Benni Mack merged patch set 2 07/04/23, 09:49