Review main Merged

79515[BUGFIX] Correct multi site FE TypoScript caches

Christian Kuhn CR +2 V +2 Easy +12 −2 updated 06/27/23, 08:28

Commit message

The v12 TypoScript parser has a nifty feature to
create the smallest possible amount of cache entries:

When two sys_template records have the same content,
when they're basically just different by their uid,
pid and maybe title, then they share the same
cache entry of their tokenized representation.

A sys_template row that has the "clear constants"
flag set, triggers inclusion of possible site
settings, which are available as constants.

When there are two different sys_template "entry"
records in a multi site instance, those sys_template
records are bound to different sites and should thus
load potentially different site settings. The
data fields of those two sys_template records may be
the same, but still need to trigger different cache
entries. Otherwise, the site settings from the request
that triggered creation of the cache entry swaps into
the other one.

To deal with this scenario, the site identifier of
the current site is now added to the cache identifier,
which leads to different cache entries in this
scenario.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 06/27/23, 07:50

  2. Christian Kuhn uploaded patch set 2 06/27/23, 07:55

  3. Jasmina Ließmann voted on patch set 2 V +1 CR +1 06/27/23, 07:57

  4. core-ci voted on patch set 1 V +1 06/27/23, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43007

  5. Markus Klein voted on patch set 2 V +1 CR +1 06/27/23, 08:01

  6. core-ci voted on patch set 2 V +1 06/27/23, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43008

  7. Benni Mack voted on patch set 2 V +1 CR +1 06/27/23, 08:24

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 06/27/23, 08:28

  9. Christian Kuhn merged patch set 3 06/27/23, 08:28