79517[TASK] Connect label with element in FormEngine
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Michael Telgkamp +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Michael Telgkamp +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 49
- Build/Sources/Sass/component/_form.scss+9 −0
- Build/Sources/Sass/component/_root.scss+3 −0
- typo3/sysext/backend/Classes/Form/Container/FlexFormElementContainer.php+16 −12
- typo3/sysext/backend/Classes/Form/Container/FlexFormEntryContainer.php+16 −1
- typo3/sysext/backend/Classes/Form/Container/PaletteAndSingleContainer.php+22 −32
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php+2 −0
- typo3/sysext/backend/Classes/Form/Element/AbstractFormElement.php+32 −0
- typo3/sysext/backend/Classes/Form/Element/BackendLayoutWizardElement.php+3 −1
- typo3/sysext/backend/Classes/Form/Element/CategoryElement.php+5 −2
- typo3/sysext/backend/Classes/Form/Element/CheckboxElement.php+3 −1
- typo3/sysext/backend/Classes/Form/Element/CheckboxLabeledToggleElement.php+3 −1
- typo3/sysext/backend/Classes/Form/Element/CheckboxToggleElement.php+3 −1
- typo3/sysext/backend/Classes/Form/Element/ColorElement.php+7 −3
- typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php+7 −3
- typo3/sysext/backend/Classes/Form/Element/EmailElement.php+7 −3
- typo3/sysext/backend/Classes/Form/Element/FileInfoElement.php+2 −0
- typo3/sysext/backend/Classes/Form/Element/FolderElement.php+6 −2
- typo3/sysext/backend/Classes/Form/Element/GroupElement.php+6 −2
- typo3/sysext/backend/Classes/Form/Element/ImageManipulationElement.php+3 −1
- typo3/sysext/backend/Classes/Form/Element/InputHiddenElement.php+2 −2
Show 29 more files
- typo3/sysext/backend/Classes/Form/Element/InputSlugElement.php+8 −4
- typo3/sysext/backend/Classes/Form/Element/InputTextElement.php+7 −3
- typo3/sysext/backend/Classes/Form/Element/JsonElement.php+6 −3
- typo3/sysext/backend/Classes/Form/Element/LinkElement.php+7 −3
- typo3/sysext/backend/Classes/Form/Element/MfaInfoElement.php+4 −1
- typo3/sysext/backend/Classes/Form/Element/NoneElement.php+6 −1
- typo3/sysext/backend/Classes/Form/Element/NumberElement.php+7 −3
- typo3/sysext/backend/Classes/Form/Element/PasswordElement.php+7 −3
- typo3/sysext/backend/Classes/Form/Element/RadioElement.php+3 −1
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+3 −1
- typo3/sysext/backend/Classes/Form/Element/SelectMultipleSideBySideElement.php+14 −6
- typo3/sysext/backend/Classes/Form/Element/SelectSingleBoxElement.php+14 −16
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php+3 −0
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php+3 −1
- typo3/sysext/backend/Classes/Form/Element/TextElement.php+7 −3
- typo3/sysext/backend/Classes/Form/Element/TextTableElement.php+6 −4
- typo3/sysext/backend/Classes/Form/Element/UnknownElement.php+6 −2
- typo3/sysext/backend/Classes/Form/Element/UserElement.php+11 −6
- typo3/sysext/backend/Classes/Form/Element/UserSysFileStorageIsPublicElement.php+5 −2
- typo3/sysext/backend/Classes/Form/Element/UuidElement.php+3 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −1
- typo3/sysext/backend/Tests/Functional/Form/MfaInfoElementTest.php+15 −0
- typo3/sysext/backend/Tests/Unit/Form/Element/DatetimeElementTest.php+1 −0
- typo3/sysext/backend/Tests/Unit/Form/Element/JsonElementTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Form/Element/UuidElementTest.php+4 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/AbstractElementsBasicCest.php+1 −1
- typo3/sysext/reactions/Classes/Form/Element/FieldMapElement.php+3 −1
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+3 −1
- typo3/sysext/t3editor/Classes/Form/Element/T3editorElement.php+3 −1
Review log 68
-
Christian Kuhn uploaded patch set 1 06/27/23, 09:19
-
core-ci voted on patch set 1 V +1 06/27/23, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43015
-
Christian Kuhn updated the commit message in patch set 2
V +106/27/23, 09:56 -
core-ci voted on patch set 2 V +1 06/27/23, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43020
-
Michael Telgkamp commented on patch set 2 V +1 CR +1 06/27/23, 11:44
It is an important accessibility improvement to connect the labels with the corresponding form fields. Thank you for this new approach to finally get the improvements into the core. -
Benni Mack voted on patch set 2 V +1 CR +1 06/27/23, 11:49
-
Christian Kuhn voted on patch set 2 V +2 CR +2 06/27/23, 11:52
-
Christian Kuhn merged patch set 3 06/27/23, 11:52