79519[BUGFIX] Avoid circular reference of COR and ServerRequest
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
Files 9
- typo3/sysext/extbase/Classes/Core/Bootstrap.php2+1 −2
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+7 −2
- typo3/sysext/frontend/Classes/ContentObject/AbstractContentObject.php+5 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+17 −20
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/frontend/Classes/DataProcessing/FlexFormProcessor.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/CaseContentObjectTest.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.php+3 −0
- typo3/sysext/frontend/Tests/Unit/DataProcessing/FlexFormProcessorTest.php+0 −4
Review log 1827
Show 12 earlier messages
-
Helmut Hummel uploaded patch set 1 06/27/23, 11:04
-
core-ci voted on patch set 1 V -1 06/27/23, 11:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43021
-
Helmut Hummel uploaded patch set 2
V -106/27/23, 11:38 -
core-ci voted on patch set 2 V +1 06/27/23, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43024
-
Helmut Hummel marked it work in progress 06/27/23, 12:13
-
Helmut Hummel uploaded patch set 3
V +106/30/23, 17:10 -
core-ci voted on patch set 3 V -1 06/30/23, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43158
-
Helmut Hummel uploaded patch set 4
V -106/30/23, 17:41 -
core-ci voted on patch set 4 V +1 06/30/23, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43161
-
Helmut Hummel uploaded patch set 5
V +107/01/23, 10:20 -
core-ci voted on patch set 5 V +1 07/01/23, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43181
-
Helmut Hummel rebased onto patch set 6
V +107/06/23, 12:45 -
core-ci voted on patch set 6 V +1 07/06/23, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43732
-
Helmut Hummel marked it ready for review 07/31/23, 17:06
-
Benni Mack voted on patch set 6 CR +1 08/01/23, 11:10
-
Christian Kuhn commented on patch set 6 CR -1 08/02/23, 09:02
looking at it. -
Benjamin Franzke commented on patch set 6 08/02/23, 10:48
In order to fix this issue this sounds good to me and valid in general, but… I just want to make one additional statement (that does for sure not block this bugfix at all, but speaks about v13). `currentContentObject` is *not* a proper request attriubute at all. All request attributes *should* be data that is derived *from* the request or represent data that belongs to the entirety of the request - no temporary data/rendering context. (And yes, I know, request is immutable and we at least do not mess with previous state/objects by using withAttribute, but I still feel like this is wrong…) The patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/77252 that added this used following justification > However, ConfigurationManager is also abused to > "park" the current ContentObjectRenderer instance …but now it is actually "parked" in the request object, which isn't any better. This is really something that needs to be tied *only* to the rendering context of a plugin – which would be RenderingContext speaking of extbase. So far I wanted to drop this, maybe to make clear: If you see any chance for (maybe even for v12) to decouple them in more placed, then that'd be great in order to maybe get rid of currentContentObject again. Thanks.Bootstrap.php:95Why is the condition swapped? We've got a proper type declaration and checking for null is perfectly fine in that case. (!instanceof is rather overhead here) -
Christian Kuhn uploaded patch set 7
CR +1V +108/02/23, 10:55 -
Christian Kuhn commented on patch set 7 08/02/23, 10:58
Reply
yeah, we're abusing it here for now. the changes however also allow us further cleanups. i think we'll continue here, refactor further, then look at it again.Bootstrap.php:95ReplyDone -
Christian Kuhn uploaded patch set 8 08/02/23, 10:59
-
core-ci voted on patch set 7 V +1 08/02/23, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44873
-
core-ci voted on patch set 8 V +1 08/02/23, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44875
-
Oliver Klee updated the commit message in patch set 9
V +108/02/23, 11:31 -
core-ci voted on patch set 9 V +1 08/02/23, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44878
-
Christian Kuhn voted on patch set 9 V +1 CR +1 08/02/23, 14:31
-
Benni Mack voted on patch set 9 V +2 CR +2 08/02/23, 14:31
-
Benni Mack merged patch set 10 08/02/23, 14:31