Review main Merged

79525[BUGFIX] Allow reconstitution of CSP hash values

Oliver Hader CR +2 V +2 Normal +127 −9 updated 06/29/23, 14:59

Commit message

Reconstituting HashValue objects from their string
representation fails and cannot be used in the site
csp.yaml settings as a consequence.

This change addresses several flaws:

* `HashValue` is used instead of `HashType` as value object
* returning potential null values by `BackedEnum::tryFrom()`
  has to be avoided, since it exits too early
* `rsort` reindexed and destroyed the array keys, which would
  have contained the relevant class names

Test cases for ModelService::buildSourceFromString() are added.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Oliver Hader uploaded patch set 1 06/27/23, 19:18

  2. Oliver Hader uploaded patch set 2 06/27/23, 19:24

  3. core-ci voted on patch set 1 V -1 06/27/23, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43046

  4. core-ci voted on patch set 2 V +1 06/27/23, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43047

  5. Markus Klein updated the commit message in patch set 3 V +1 06/27/23, 22:19

  6. core-ci voted on patch set 3 V +1 06/27/23, 22:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43049

  7. Torben Hansen voted on patch set 3 V +1 CR +1 06/28/23, 05:45

  8. Markus Klein voted on patch set 3 V +1 CR +1 06/28/23, 08:17

  9. Oliver Hader voted on patch set 3 V +2 CR +2 06/29/23, 14:58

  10. Oliver Hader merged patch set 4 06/29/23, 14:59