79531[!!!][TASK] Enforce strict typing in UnableToLinkException
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 3
Files 2
Review log 1417
-
Thomas Hohn uploaded patch set 1 06/28/23, 12:19
-
core-ci voted on patch set 1 V +1 06/28/23, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43071
-
Oliver Klee commented on patch set 1 06/28/23, 12:57
-
Thomas Hohn commented on patch set 1 06/28/23, 13:15
UnableToLinkException.php:40ReplySo change it to ?\Throwable -
Thomas Hohn uploaded patch set 2
V +106/28/23, 13:27 -
core-ci voted on patch set 2 V +1 06/28/23, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43072
-
Thomas Hohn commented on patch set 2 06/28/23, 13:41
UnableToLinkException.php:40ReplyDone -
Oliver Klee voted on patch set 2 V +1 CR +1 06/28/23, 13:51
-
Jörg Bösche voted on patch set 2 CR +1 07/07/23, 12:03
-
Oliver Klee commented on patch set 2 07/07/23, 12:09
UnableToLinkException.php:28Maybe we can remove this `@var` annotation now. (It looks to be incomplete anyway.)UnableToLinkException.php:38Maybe we can drop the complete documentation block as it does not add anything substantial over the native type declarations. What do you think? -
Oliver Klee commented on patch set 2 07/15/23, 11:26
UnableToLinkException.php:28ReplyDoneUnableToLinkException.php:38ReplyDone -
Oliver Klee uploaded patch set 3
CR +1V +107/15/23, 11:27 -
Oliver Klee commented on patch set 2 V 0 CR 0 07/15/23, 11:28
As this is a breaking change, we cannot backport this to 12.4 according to our policy. -
Oliver Klee voted on patch set 3 V +1 CR +1 07/15/23, 11:28
-
core-ci voted on patch set 3 V +1 07/15/23, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44170
-
Stefan Bürk voted on patch set 3 V +2 CR +2 07/21/23, 20:44
-
Stefan Bürk merged patch set 4 07/21/23, 20:44
UnableToLinkException.php:40