Review 12.4 Merged

79541[BUGFIX] Do not return exit codes > 255

Andreas Kienast CR +2 V +2 Easy +4 −0 updated 07/03/23, 11:21

Commit message

If a console command throws an exception that isn't caught, the exit
code evaluates to "0" (aka successful) because the exit codes usually
are the exception timestamp and UNIX doesn't support exit codes > 255.

The issue is now solved by checking the exit code in
`CommandApplication` and setting an upper bound of 255.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Andreas Kienast commented on patch set 1 07/03/23, 11:01

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/03/23, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43218

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 07/03/23, 11:21

  4. Andreas Kienast merged patch set 2 07/03/23, 11:21