Review main Merged

79552[BUGFIX] Add identifier to the file mount cache's value

TYPO3com CR +2 V +2 Easy +9 −5 updated 07/05/23, 07:15

Commit message

This makes the groupHomePath and userHomePath features available
again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stig Nørgaard Færch +1
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1524

  1. TYPO3com uploaded patch set 1 06/28/23, 14:11

  2. core-ci voted on patch set 1 V -1 06/28/23, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43074

  3. Stig Nørgaard Færch commented on patch set 1 CR -1 06/28/23, 14:20

    Missing comma
  4. Stig Nørgaard Færch commented on patch set 2 CR -1 V -1 06/28/23, 14:33

    Published edit on patch set 1.
  5. core-ci voted on patch set 2 V -1 06/28/23, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43076

  6. Stefan Bürk wrote 06/28/23, 18:22

    Change destination moved from 12.4 to main
  7. Stefan Bürk rebased onto patch set 3 V -1 06/28/23, 18:22

  8. Stefan Bürk updated the commit message in patch set 4 06/28/23, 18:23

  9. Stefan Bürk commented on patch set 5 06/28/23, 18:24

    Published edit on patch set 4.
  10. Stefan Bürk updated the commit message in patch set 6 06/28/23, 18:30

  11. core-ci voted on patch set 3 V -1 06/28/23, 18:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43079

  12. core-ci voted on patch set 4 V -1 06/28/23, 18:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43080

  13. core-ci voted on patch set 5 V +1 06/28/23, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43081

  14. core-ci voted on patch set 6 V +1 06/28/23, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43082

  15. Markus Klein updated the commit message in patch set 7 V +1 06/28/23, 20:08

  16. Markus Klein commented on patch set 7 06/28/23, 20:12

    I closed the duplicated issue and reference only the initial one here.

    BackendUserAuthentication.php:1371

    I'm not sure if our CGL actually allows for this string interpolation syntax.
  17. core-ci voted on patch set 7 V +1 06/28/23, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43087

  18. Benni Mack uploaded patch set 8 V +1 07/04/23, 21:13

  19. Benni Mack commented on patch set 8 V +1 CR +1 07/04/23, 21:13

    Reply

    Done

    BackendUserAuthentication.php:1371 Reply

    Done
  20. core-ci voted on patch set 8 V +1 07/04/23, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43443

  21. Markus Klein voted on patch set 8 V +1 CR +1 07/05/23, 04:46

  22. Stig Nørgaard Færch commented on patch set 8 CR +1 07/05/23, 05:23

    Reply

    Done
  23. Benni Mack voted on patch set 8 V +2 CR +2 07/05/23, 07:15

  24. Benni Mack merged patch set 9 07/05/23, 07:15