Review main Merged

79564[BUGFIX] Fix counting of doktypes in DatabaseIntegrityCheck

Nikita Hovratov CR +2 V +2 Easy +1 −4 updated 06/30/23, 17:42

Commit message

The previous logic for checking whether a value for a specific
doktype already exists falsely assumed the value should be an
array. This is now fixed by using the null coalescing assignment,
which is available since PHP 7.4.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Nikita Hovratov uploaded patch set 1 06/29/23, 15:24

  2. core-ci voted on patch set 1 V +1 06/29/23, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43123

  3. Benni Mack voted on patch set 1 V +1 CR +1 06/30/23, 09:49

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 06/30/23, 17:42

  5. Oli Bartsch merged patch set 2 06/30/23, 17:42